Error messages due to invalid logging optimization

[em-al-wi]

What Happened?

Since version 1.8.4 error messages in the log appear whenever a service response is not a JSON document or the JSON is longer then 1,000 characters.

ERROR SyntaxError: Unterminated string in JSON at position 1003 at JSON.parse (<anonymous>) at Fi (file:///usr/src/app/node_modules/.pnpm/@[email protected]/node_modules/@portkey-ai/gateway/build/start-server.js:2:260672) at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

What Should Have Happened?

No error messages.

Relevant Code Snippet

The commit introducing the error: cf25af7

The change does not take into account that a response is not always json. And if it is json but longer than 1,000 characters, it truncates the json and tries to parse it.

src/middlewares/log/index.ts:
JSON.parse(responseString.substring(0, maxLength) + '...')

Your Twitter/LinkedIn

No response