fix: address CI failures and code review comments

- Add permissions: contents: read to CI workflow (security best practice)
- Exclude test_project_django5 from main pytest run to avoid name collision
- Fix ruff E712: use truth check instead of == True
- Add noqa: E402 for unavoidable Django setup imports
- Configure testpaths to only run posthog/test in main CI

Author: webjunkie

.claude/settings.local.json

@@ -0,0 +1,24 @@
+{
+  "permissions": {
+    "allow": [
+      "Bash(uv run mypy:*)",
+      "WebFetch(domain:code.djangoproject.com)",
+      "Bash(uv run pytest:*)",
+      "Bash(gh issue view:*)",
+      "Read(//Users/julian/workspace/posthog/**)",
+      "Bash(flox activate:*)",
+      "Bash(curl:*)",
+      "Bash(pip show:*)",
+      "Bash(uvx:*)",
+      "Bash(uv sync:*)",
+      "Bash(DJANGO_SETTINGS_MODULE=testdjango.settings uv --project /Users/julian/workspace/posthog-python/test_project_django5 run uvicorn testdjango.asgi:application --host 127.0.0.1 --port 8001)",
+      "Read(//tmp/**)",
+      "Bash(DJANGO_SETTINGS_MODULE=testdjango.settings uv run uvicorn:*)",
+      "Bash(uv run:*)",
+      "Bash(uv pip list:*)",
+      "Bash(ruff check:*)"
+    ],
+    "deny": [],
+    "ask": []
+  }
+}

.github/workflows/ci.yml

@@ -3,6 +3,9 @@ name: CI
 on:
     - pull_request
 
+permissions:
+    contents: read
+
 jobs:
     code-quality:
         name: Code quality checks

posthog/client.py

@@ -3,7 +3,7 @@
 import os
 import sys
 from datetime import datetime, timedelta
-from typing import Any, Callable, Dict, Optional, Union
+from typing import Any, Dict, Optional, Union
 from typing_extensions import Unpack
 from uuid import uuid4
 
@@ -60,7 +60,6 @@
     SizeLimitedDict,
     clean,
     guess_timezone,
-    remove_trailing_slash,
     system_context,
 )
 from posthog.version import VERSION

posthog/test/ai/anthropic/test_anthropic.py

@@ -1,4 +1,3 @@
-import os
 from unittest.mock import patch
 
 import pytest

pyproject.toml

@@ -96,3 +96,5 @@ version = { attr = "posthog.version.VERSION" }
 [tool.pytest.ini_options]
 asyncio_mode = "auto"
 asyncio_default_fixture_loop_scope = "function"
+testpaths = ["posthog/test"]
+norecursedirs = ["test_project_django5"]

test_project_django5/manage.py

@@ -1,12 +1,13 @@
 #!/usr/bin/env python
 """Django's command-line utility for administrative tasks."""
+
 import os
 import sys
 
 
 def main():
     """Run administrative tasks."""
-    os.environ.setdefault('DJANGO_SETTINGS_MODULE', 'testdjango.settings')
+    os.environ.setdefault("DJANGO_SETTINGS_MODULE", "testdjango.settings")
     try:
         from django.core.management import execute_from_command_line
     except ImportError as exc:
@@ -18,5 +19,5 @@ def main():
     execute_from_command_line(sys.argv)
 
 
-if __name__ == '__main__':
+if __name__ == "__main__":
     main()

test_project_django5/pyproject.toml

@@ -12,5 +12,8 @@ dependencies = [
     "httpx~=0.28.1",
 ]
 
+[tool.uv]
+required-version = ">=0.5"
+
 [tool.uv.sources]
 posthog = { path = "..", editable = true }

test_project_django5/test_exception_capture.py

@@ -8,16 +8,17 @@
 With process_exception(), Django calls this method to capture exceptions before
 converting them to 500 responses.
 """
+
 import os
 import django
 
 # Setup Django before importing anything else
 os.environ.setdefault("DJANGO_SETTINGS_MODULE", "testdjango.settings")
 django.setup()
 
-import pytest
-from httpx import AsyncClient, ASGITransport
-from django.core.asgi import get_asgi_application
+import pytest  # noqa: E402
+from httpx import AsyncClient, ASGITransport  # noqa: E402
+from django.core.asgi import get_asgi_application  # noqa: E402
 
 
 @pytest.fixture(scope="session")
@@ -41,27 +42,31 @@ async def test_async_exception_is_captured(asgi_app):
 
     def mock_capture(exception, **kwargs):
         """Mock capture_exception to record calls."""
-        captured.append({
-            'exception': exception,
-            'type': type(exception).__name__,
-            'message': str(exception)
-        })
+        captured.append(
+            {
+                "exception": exception,
+                "type": type(exception).__name__,
+                "message": str(exception),
+            }
+        )
 
     # Patch at the posthog module level where middleware imports from
-    with patch('posthog.capture_exception', side_effect=mock_capture):
-        async with AsyncClient(transport=ASGITransport(app=asgi_app), base_url="http://testserver") as ac:
+    with patch("posthog.capture_exception", side_effect=mock_capture):
+        async with AsyncClient(
+            transport=ASGITransport(app=asgi_app), base_url="http://testserver"
+        ) as ac:
             response = await ac.get("/test/async-exception")
 
         # Django returns 500
         assert response.status_code == 500
 
         # CRITICAL: Verify PostHog captured the exception
-        assert len(captured) > 0, f"Exception was NOT captured to PostHog!"
+        assert len(captured) > 0, "Exception was NOT captured to PostHog!"
 
         # Verify it's the right exception
         exception_data = captured[0]
-        assert exception_data['type'] == 'ValueError'
-        assert 'Test exception from Django 5 async view' in exception_data['message']
+        assert exception_data["type"] == "ValueError"
+        assert "Test exception from Django 5 async view" in exception_data["message"]
 
 
 @pytest.mark.asyncio
@@ -79,24 +84,28 @@ async def test_sync_exception_is_captured(asgi_app):
 
     def mock_capture(exception, **kwargs):
         """Mock capture_exception to record calls."""
-        captured.append({
-            'exception': exception,
-            'type': type(exception).__name__,
-            'message': str(exception)
-        })
+        captured.append(
+            {
+                "exception": exception,
+                "type": type(exception).__name__,
+                "message": str(exception),
+            }
+        )
 
     # Patch at the posthog module level where middleware imports from
-    with patch('posthog.capture_exception', side_effect=mock_capture):
-        async with AsyncClient(transport=ASGITransport(app=asgi_app), base_url="http://testserver") as ac:
+    with patch("posthog.capture_exception", side_effect=mock_capture):
+        async with AsyncClient(
+            transport=ASGITransport(app=asgi_app), base_url="http://testserver"
+        ) as ac:
             response = await ac.get("/test/sync-exception")
 
         # Django returns 500
         assert response.status_code == 500
 
         # CRITICAL: Verify PostHog captured the exception
-        assert len(captured) > 0, f"Exception was NOT captured to PostHog!"
+        assert len(captured) > 0, "Exception was NOT captured to PostHog!"
 
         # Verify it's the right exception
         exception_data = captured[0]
-        assert exception_data['type'] == 'ValueError'
-        assert 'Test exception from Django 5 sync view' in exception_data['message']
+        assert exception_data["type"] == "ValueError"
+        assert "Test exception from Django 5 sync view" in exception_data["message"]

test_project_django5/test_middleware.py

@@ -8,16 +8,17 @@
 
 Tests run directly against the ASGI application without needing a server.
 """
+
 import os
 import django
 
 # Setup Django before importing anything else
 os.environ.setdefault("DJANGO_SETTINGS_MODULE", "testdjango.settings")
 django.setup()
 
-import pytest
-from httpx import AsyncClient, ASGITransport
-from django.core.asgi import get_asgi_application
+import pytest  # noqa: E402
+from httpx import AsyncClient, ASGITransport  # noqa: E402
+from django.core.asgi import get_asgi_application  # noqa: E402
 
 
 @pytest.fixture(scope="session")
@@ -38,7 +39,9 @@ async def test_async_user_access(asgi_app):
     trigger the lazy loading bug. This test verifies the middleware works
     in the common case.
     """
-    async with AsyncClient(transport=ASGITransport(app=asgi_app), base_url="http://testserver") as ac:
+    async with AsyncClient(
+        transport=ASGITransport(app=asgi_app), base_url="http://testserver"
+    ) as ac:
         response = await ac.get("/test/async-user")
 
     assert response.status_code == 200
@@ -74,13 +77,13 @@ async def test_async_authenticated_user_access(asgi_app):
     @sync_to_async
     def create_or_get_user():
         user, created = User.objects.get_or_create(
-            username='testuser',
+            username="testuser",
             defaults={
-                'email': '[email protected]',
-            }
+                "email": "[email protected]",
+            },
         )
         if created:
-            user.set_password('testpass123')
+            user.set_password("testpass123")
             user.save()
         return user
 
@@ -91,7 +94,7 @@ def create_or_get_user():
     def create_session():
         client = Client()
         client.force_login(user)
-        return client.cookies.get('sessionid')
+        return client.cookies.get("sessionid")
 
     session_cookie = await create_session()
 
@@ -104,14 +107,14 @@ def create_session():
         async with AsyncClient(
             transport=ASGITransport(app=asgi_app),
             base_url="http://testserver",
-            cookies={"sessionid": session_cookie.value}
+            cookies={"sessionid": session_cookie.value},
         ) as ac:
             response = await ac.get("/test/async-user")
 
         assert response.status_code == 200
         data = response.json()
         assert data["status"] == "success"
-        assert data["user_authenticated"] == True
+        assert data["user_authenticated"]
 
 
 @pytest.mark.asyncio
@@ -121,7 +124,9 @@ async def test_sync_user_access(asgi_app):
 
     This should always work regardless of middleware version.
     """
-    async with AsyncClient(transport=ASGITransport(app=asgi_app), base_url="http://testserver") as ac:
+    async with AsyncClient(
+        transport=ASGITransport(app=asgi_app), base_url="http://testserver"
+    ) as ac:
         response = await ac.get("/test/sync-user")
 
     assert response.status_code == 200
@@ -139,7 +144,9 @@ async def test_async_exception_capture(asgi_app):
     causes a 500 response. See test_exception_capture.py for tests that verify
     actual exception capture to PostHog.
     """
-    async with AsyncClient(transport=ASGITransport(app=asgi_app), base_url="http://testserver") as ac:
+    async with AsyncClient(
+        transport=ASGITransport(app=asgi_app), base_url="http://testserver"
+    ) as ac:
         response = await ac.get("/test/async-exception")
 
     # Django returns 500 for unhandled exceptions
@@ -154,7 +161,9 @@ async def test_sync_exception_capture(asgi_app):
     The middleware's process_exception() method captures view exceptions to PostHog.
     This test verifies the exception causes a 500 response.
     """
-    async with AsyncClient(transport=ASGITransport(app=asgi_app), base_url="http://testserver") as ac:
+    async with AsyncClient(
+        transport=ASGITransport(app=asgi_app), base_url="http://testserver"
+    ) as ac:
         response = await ac.get("/test/sync-exception")
 
     # Django returns 500 for unhandled exceptions

test_project_django5/testdjango/asgi.py

@@ -11,6 +11,6 @@
 
 from django.core.asgi import get_asgi_application
 
-os.environ.setdefault('DJANGO_SETTINGS_MODULE', 'testdjango.settings')
+os.environ.setdefault("DJANGO_SETTINGS_MODULE", "testdjango.settings")
 
 application = get_asgi_application()