Refactor + Tests for Get-ModuleExtension

Author: HeyItsGilbert

Plaster/Private/Get-ModuleExtension.ps1

@@ -61,8 +61,18 @@ function Get-ModuleExtension {
 
                 Write-Verbose "Comparing against module extension: $($extension.Module)"
 
-                $minimumVersion = Resolve-ModuleVersionString $extension.MinimumVersion
-                $maximumVersion = Resolve-ModuleVersionString $extension.MaximumVersion
+                if ([String]::IsNullOrEmpty($extension.MinimumVersion)) {
+                    # Fill with a default value if not specified
+                    $minimumVersion = $null
+                } else {
+                    $minimumVersion = Resolve-ModuleVersionString $extension.MinimumVersion
+                }
+                if ([String]::IsNullOrEmpty($extension.MaximumVersion)) {
+                    # Fill with a default value if not specified
+                    $maximumVersion = $null
+                } else {
+                    $maximumVersion = Resolve-ModuleVersionString $extension.MaximumVersion
+                }
 
                 if (($extension.Module -eq $ModuleName) -and
                     (!$minimumVersion -or $ModuleVersion -ge $minimumVersion) -and

Plaster/Private/Resolve-ModuleVersionString.ps1

@@ -23,36 +23,30 @@ function Resolve-ModuleVersionString {
     It is not intended for direct use outside of the Plaster context.
     #>
     param(
-        [Parameter(Mandatory)]
+        [Parameter(Mandatory, Position = 0)]
         [ValidateNotNullOrEmpty()]
-        [string]
-        $versionString
+        $VersionString
     )
-    $parsedVersion = $null
 
-    if ($versionString) {
-        # We're targeting Semantic Versioning 2.0 so make sure the version has
-        # at least 3 components (X.X.X).  This logic ensures that the "patch"
-        # (third) component has been specified.
-        $versionParts = $versionString.Split('.')
-        if ($versionParts.Length -lt 3) {
-            $versionString = "$versionString.0"
-        }
+    # We're targeting Semantic Versioning 2.0 so make sure the version has
+    # at least 3 components (X.X.X).  This logic ensures that the "patch"
+    # (third) component has been specified.
+    $versionParts = $VersionString.Split('.')
+    if ($versionParts.Length -lt 3) {
+        $VersionString = "$VersionString.0"
+    }
 
-        if ($PSVersionTable.PSEdition -eq "Core") {
-            $newObjectSplat = @{
-                TypeName = "System.Management.Automation.SemanticVersion"
-                ArgumentList = $versionString
-            }
-            $parsedVersion = New-Object @newObjectSplat
-        } else {
-            $newObjectSplat = @{
-                TypeName = "System.Version"
-                ArgumentList = $versionString
-            }
-            $parsedVersion = New-Object @newObjectSplat
+    if ($PSVersionTable.PSEdition -eq "Core") {
+        $newObjectSplat = @{
+            TypeName = "System.Management.Automation.SemanticVersion"
+            ArgumentList = $VersionString
         }
+        return New-Object @newObjectSplat
+    } else {
+        $newObjectSplat = @{
+            TypeName = "System.Version"
+            ArgumentList = $VersionString
+        }
+        return New-Object @newObjectSplat
     }
-
-    return $parsedVersion
 }