Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace creation blocked by admission controller #934

Open
micmax93 opened this issue Jan 7, 2025 · 1 comment
Open

Namespace creation blocked by admission controller #934

micmax93 opened this issue Jan 7, 2025 · 1 comment

Comments

@micmax93
Copy link

micmax93 commented Jan 7, 2025

Creating a namespace with specified labels & annotations is split into multiple requests in helmsman:
https://github.com/Praqma/helmsman/blob/master/internal/app/kube_helpers.go#L27-L29

This becomes an issue if admission controller is deployed and has policies enforcing Namespaces to have some mandatory labels, for example: pod security standard labels, Istio version or ownership.
Admission controller enforces policy on request level - in this case namespaces creation, which Helmsman performs always without any labels.

A possible solution would be to create a namespace with all attributes in a single request with kubectl apply

@micmax93
Copy link
Author

micmax93 commented Jan 7, 2025

Here is proposal on how to address this issue: #935

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant