Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 16 Support for OSX M1 arm64 #31

Open
tzjames opened this issue Jul 22, 2021 · 7 comments
Open

Node 16 Support for OSX M1 arm64 #31

tzjames opened this issue Jul 22, 2021 · 7 comments

Comments

@tzjames
Copy link

tzjames commented Jul 22, 2021

I'm on an OSX M1. When running npm i native-image-diff I get:

npm ERR! Downloading native-image-diff prebuilt binary from "https://github.com/Prior99/native-image-diff/releases/download/0.1.14/native-image-diff-darwin-arm64-93.node".
npm ERR! Error: No supported native-image-diff 0.1.14 build found for node v16.1.0 on darwin (arm64).
npm ERR!     at Request.<anonymous> (/xxx/node_modules/native-image-diff/scripts/install.js:38:19)
npm ERR!     at Request.emit (node:events:365:28)
npm ERR!     at Request.onRequestResponse (/xxx/node_modules/request/request.js:1059:10)
npm ERR!     at ClientRequest.emit (node:events:365:28)
npm ERR!     at HTTPParser.parserOnIncomingClient [as onIncoming] (node:_http_client:621:27)
npm ERR!     at HTTPParser.parserOnHeadersComplete (node:_http_common:127:17)
npm ERR!     at TLSSocket.socketOnData (node:_http_client:487:22)
npm ERR!     at TLSSocket.emit (node:events:365:28)
npm ERR!     at addChunk (node:internal/streams/readable:314:12)
npm ERR!     at readableAddChunk (node:internal/streams/readable:289:9)

Is there any work around?

@Prior99
Copy link
Owner

Prior99 commented Jul 26, 2021

Sadly, no. There are no prebuilt binaries for that platform.

@tfactor2
Copy link

tfactor2 commented Nov 6, 2021

Still, any workarounds? Apple M1 becomes a very popular machine for development.

@tujoworker
Copy link

@Prior99 Could pixelmatch which uses pngjs an option?

Do you know more about these? What about speed? They do not use libpng. For me it seems that libpng is not maintained. A lot of PRs and issues over there. But no releases.

@Prior99
Copy link
Owner

Prior99 commented Nov 19, 2021

@tfactor2 I am open for a PR adding some kind of CI support.
@tujoworker pixelmatch and pngjs indeed do not use libpng, which makes them slow. This was the whole idea behind creating this library. There is nothing wrong with switching to them, but you'd sacrifice around 10 times the performance (See README).

I will not add support for a machine I do not own and use.
Apple makes it notoriously complicated to compile stuff for their hardware.
Sorry.

@svenstaro
Copy link
Contributor

@Prior99 Any progress on this?

@Prior99
Copy link
Owner

Prior99 commented May 10, 2022

@svenstaro I would be happy to accept a PR introducing some kind of CI support for this. I currently don't actively use this package and have no capacity to implement new features, especially if I don't have the hardware to test this.

@tfactor2
Copy link

@Prior99, could you point to a valid build pipeline, plz?
https://travis-ci.org/Prior99/native-image-diff doesn't work for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants