Fix eslint errors

Author: markusjwetzel

.eslintrc

@@ -0,0 +1,17 @@
+{
+  "extends": "./src/config/eslint.js",
+  "rules": {
+    // Since most of the files in this project don't use ES6, we need to change a
+    // few rules from our base ESLint configuration.
+    "comma-dangle": [
+      "error",
+      {
+        "arrays": "always-multiline",
+        "objects": "always-multiline",
+        "imports": "always-multiline",
+        "exports": "always-multiline",
+        "functions": "ignore"
+      }
+    ]
+  }
+}

package.json

@@ -22,6 +22,7 @@
   },
   "scripts": {},
   "dependencies": {
+    "autoprefixer": "6.7.7",
     "babel-cli": "6.24.1",
     "babel-core": "6.24.1",
     "babel-eslint": "7.2.2",
@@ -43,9 +44,6 @@
     "eslint-import-resolver-node": "0.3.0",
     "eslint-loader": "1.7.1",
     "eslint-plugin-flowtype": "2.30.4",
-    "eslint-plugin-import": "2.2.0",
-    "eslint-plugin-jsx-a11y": "4.0.0",
-    "eslint-plugin-react": "6.10.3",
     "express": "4.15.2",
     "extract-text-webpack-plugin": "2.1.0",
     "file-loader": "0.11.1",

src/bootstrap/client/start.js

@@ -24,10 +24,11 @@ hydrate(meta, { render }, data);
 if (process.env.APP_MODE === 'development') {
   window.React = React; // enable debugger
 
-  if (!dest
-    || !dest.firstChild
-    || !dest.firstChild.attributes
-    || !dest.firstChild.attributes['data-react-checksum']
+  if (
+    !dest ||
+    !dest.firstChild ||
+    !dest.firstChild.attributes ||
+    !dest.firstChild.attributes['data-react-checksum']
   ) {
     // eslint-disable-next-line no-console
     console.error('React server rendering was discarded.');

src/bootstrap/server/createHttpServer.js

@@ -13,7 +13,7 @@ module.exports = function createHttpServer(config) {
   const server = new http.Server(app);
 
   // proxy middleware
-  config.proxies.forEach((proxy) => {
+  config.proxies.forEach(proxy => {
     app.use(proxy.path, createProxy(proxy, server));
   });
 
@@ -38,17 +38,20 @@ module.exports = function createHttpServer(config) {
 
   // start server
   if (config.port && config.host) {
-    server.listen(config.port, config.host, function(err) {
+    server.listen(config.port, config.host, err => {
       if (err) {
+        // eslint-disable-next-line no-console
         console.error(err);
       }
+      // eslint-disable-next-line no-console
       console.info(
         '\n~~> Node.js server is running.\n    Open',
         `\x1b[93mhttp://localhost:${config.port}\x1b[0m`,
         'in a browser to view the app.\n'
       );
     });
   } else {
+    // eslint-disable-next-line no-console
     console.error('ERROR: No PORT or HOST config variable has been specified');
   }
 };

src/bootstrap/server/createReactAppOnServer.js

@@ -1,4 +1,3 @@
-const React = require('react');
 const ReactDOM = require('react-dom/server');
 // const 'isomorphic-fetch';
 const addCookie = require('../utils/addCookie');
@@ -16,11 +15,14 @@ module.exports = function createAppOnServer(config) {
   return (req, res) => {
     // try to find locale from url, header and cookies
     const localeFromUrl = getLocaleFromUrl(req.originalUrl, config.app.locale.supported);
-    const localeFromHeader = getLocaleFromHeader(req.headers['accept-language'], config.app.locale.supported);
+    const localeFromHeader = getLocaleFromHeader(
+      req.headers['accept-language'],
+      config.app.locale.supported
+    );
     const localeFromCookies = getLocaleFromCookies(req.cookies, config.app.locale.supported);
 
     const url = req.url;
-    const urlWithoutLocale = (localeFromUrl)
+    const urlWithoutLocale = localeFromUrl
       ? stripLocaleFromUrl(req.originalUrl, localeFromUrl)
       : req.originalUrl;
 
@@ -38,7 +40,7 @@ module.exports = function createAppOnServer(config) {
       addCookie(req, res, {
         name: 'lang',
         value: locale,
-        options: { maxAge: 2628000 * 60 * 1000 } // 5 years lifetime
+        options: { maxAge: 2628000 * 60 * 1000 }, // 5 years lifetime
       });
     }
 
@@ -57,7 +59,7 @@ module.exports = function createAppOnServer(config) {
       addCookie(req, res, {
         name: 'csrf',
         value: csrfToken,
-        options: { httpOnly: true }
+        options: { httpOnly: true },
       });
     }
 
@@ -82,15 +84,17 @@ module.exports = function createAppOnServer(config) {
     if (process.env.APP_MODE === 'development') {
       delete require.cache[paths.webpackAssets];
 
-      Object.keys(require.cache).forEach(function(id) {
-        if (/[\/\\]app[\/\\]/.test(id)) delete require.cache[id];
+      Object.keys(require.cache).forEach(id => {
+        if (/[/\\]app[/\\]/.test(id)) delete require.cache[id];
       });
     }
 
     // define render, redirect and error function for hydrate function
     const render = (component, data) => {
+      // eslint-disable-next-line
       const assets = require(paths.webpackAssets);
       const content = component ? ReactDOM.renderToString(component) : '';
+      // eslint-disable-next-line
       const renderHtml = require(paths.appHtml).default;
 
       const htmlSnippets = generateHtmlSnippets(meta, content, assets, data, config.devBuild.dll);
@@ -99,15 +103,15 @@ module.exports = function createAppOnServer(config) {
 
       res.status(200).send(html);
     };
-    const redirect = (path) => {
+    const redirect = path => {
       res.redirect(path);
-    }
-    const error = (message, status) => {
+    };
+    const error = message => {
       res.status(404);
       if (message) {
-        res.send(message)
+        res.send(message);
       }
-    }
+    };
 
     // Render page on client if server side rendering is disabled.
     // Initial state should be empty in this case.
@@ -117,7 +121,8 @@ module.exports = function createAppOnServer(config) {
     }
 
     // get hydrate function and hydrate
+    // eslint-disable-next-line
     const hydrate = require(paths.appServerEntry).default;
     hydrate(meta, { error, redirect, render });
   };
-};
+};

src/bootstrap/server/defaultConfig.js

@@ -1,5 +1,3 @@
-const paths = require('../../config/paths');
-
 module.exports = {
   host: 'localhost',
   port: 8080,
@@ -14,10 +12,10 @@ module.exports = {
       supported: ['en'],
     },
     device: {
-      autoDetect: true
+      autoDetect: true,
     },
   },
   devBuild: {
     dll: false,
-  }
+  },
 };

src/bootstrap/server/run.js

@@ -12,8 +12,10 @@ module.exports = function runServer(customConfig) {
   const config = deepmerge(defaultConfig, customConfig);
 
   // define process.env.NODE_PATH for imports
+  // eslint-disable-next-line global-require
   const Module = require('module').Module;
   process.env.NODE_PATH = paths.appMain;
+  // eslint-disable-next-line no-underscore-dangle
   Module._initPaths();
 
   // define app process.env constants
@@ -22,9 +24,12 @@ module.exports = function runServer(customConfig) {
   process.env.APP_PLATFORM = 'web';
 
   // define webpackIsomorphicTools constant
-  new WebpackIsomorphicTools(require('../../config/webpackIsomorphicTools'))
-    .server(paths.appRoot, function() {
-      const createHttpServer = require('./createHttpServer');
-      createHttpServer(config);
-    });
+  new WebpackIsomorphicTools(
+    // eslint-disable-next-line global-require
+    require('../../config/webpackIsomorphicTools')
+  ).server(paths.appRoot, () => {
+    // eslint-disable-next-line global-require
+    const createHttpServer = require('./createHttpServer');
+    createHttpServer(config);
+  });
 };

src/bootstrap/utils/addCookie.js

@@ -9,4 +9,4 @@ module.exports = function addCookie(req, res, data) {
     req.headers.cookie = `${req.headers.cookie};${data.name}=${data.value}`;
   }
   res.cookie(data.name, data.value, data.options);
-}
+};

src/bootstrap/utils/createProxy.js

@@ -4,6 +4,7 @@ function proxyError(error, req, res) {
   // add the error handling
   // https://github.com/nodejitsu/node-http-proxy/issues/527
   if (error.code !== 'ECONNRESET') {
+    // eslint-disable-next-line no-console
     console.error('proxy error', error);
   }
   if (!res.headersSent) {
@@ -12,7 +13,7 @@ function proxyError(error, req, res) {
 
   const json = { error: 'proxy_error', reason: error.message };
   res.end(JSON.stringify(json));
-};
+}
 
 module.exports = function createProxy(options, server) {
   const proxy = httpProxy.createProxyServer(options);

src/bootstrap/utils/detectDevice.js

@@ -17,12 +17,10 @@ module.exports = function detectDevice(userAgent, cookie, auto) {
     if (md.phone() !== null) {
       // phone
       return 'mobile';
-    } else {
-      // tablet
-      return 'desktop';
     }
-  } else {
-    // desktop
+    // tablet
     return 'desktop';
   }
+  // desktop
+  return 'desktop';
 };