Pass language to File::getDimensionsString for MediaWiki 1.47 compatibility

Fixes #47

File::getDimensionsString() gained a required $lang parameter in MediaWiki 1.47
(optional since 1.46), so calling it without arguments threw an
ArgumentCountError when rendering local media values. Passing the content
language works across the whole supported range: it is harmlessly ignored on
1.45 and earlier, satisfies the optional parameter on 1.46, and the required one
on 1.47+.

The existing formatting tests format a non-existent file and never reach the
metadata path. InlineImageFormatterTest stubs RepoGroup to return a file,
exercising getDimensionsString so a regression is caught on versions where the
parameter is required.

CI: add REL1_44/45/46 to the matrix, and repair the install script so the
matrix runs again: disable Composer 2.10's security-advisory blocking (older
branches pin flagged dependency versions) and allow dev/beta stability for the
master job's Wikibase dependencies.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: JeroenDeDauw

.github/workflows/ci.yml

@@ -30,6 +30,15 @@ jobs:
           - mw: 'REL1_43'
             php: 8.3
             experimental: false
+          - mw: 'REL1_44'
+            php: 8.2
+            experimental: false
+          - mw: 'REL1_45'
+            php: 8.3
+            experimental: false
+          - mw: 'REL1_46'
+            php: 8.4
+            experimental: false
           - mw: 'master'
             php: 8.4
             experimental: true

.github/workflows/installMediaWiki.sh

@@ -10,6 +10,16 @@ mv mediawiki-$MW_BRANCH mediawiki
 
 cd mediawiki
 
+# Composer 2.10+ refuses to install dependency versions flagged by security advisories.
+# Older MediaWiki branches pin such versions; allow them here as this is a throwaway CI install.
+php -r '$f = "composer.json"; $c = json_decode( file_get_contents( $f ), true ); $c["config"]["policy"]["advisories"]["block"] = false; file_put_contents( $f, json_encode( $c, JSON_PRETTY_PRINT | JSON_UNESCAPED_SLASHES | JSON_UNESCAPED_UNICODE ) . "\n" );'
+
+# Wikibase's development branch pulls in beta/dev stability dependencies.
+if [ "$MW_BRANCH" == "master" ]; then
+  composer config minimum-stability dev
+  composer config prefer-stable true
+fi
+
 composer install
 php maintenance/install.php --dbtype sqlite --dbuser root --dbname mw --dbpath $(pwd) --pass AdminPassword WikiName AdminUser
 

src/Services/InlineImageFormatter.php

@@ -136,7 +136,8 @@ private function getCaptionHtml( Title $title, ?File $file = null ): string {
 
 	private function getFileMetaHtml( File $file ): string {
 		return $this->language->semicolonList( [
-			$file->getDimensionsString(),
+			// @phpstan-ignore arguments.count ($lang required since MW 1.47, ignored on older versions)
+			$file->getDimensionsString( $this->language ),
 			htmlspecialchars( $this->language->formatSize( (int)$file->getSize() ) )
 		] );
 	}

tests/php/Integration/InlineImageFormatterTest.php

@@ -0,0 +1,60 @@
+<?php
+
+declare( strict_types = 1 );
+
+namespace Wikibase\LocalMedia\Tests\Integration;
+
+use DataValues\StringValue;
+use File;
+use MediaWiki\MainConfigNames;
+use MediaWikiIntegrationTestCase;
+use ParserOptions;
+use RepoGroup;
+use Wikibase\LocalMedia\Services\InlineImageFormatter;
+use Wikibase\LocalMedia\Services\LocalImageLinker;
+
+/**
+ * @covers \Wikibase\LocalMedia\Services\InlineImageFormatter
+ */
+class InlineImageFormatterTest extends MediaWikiIntegrationTestCase {
+
+	public function testFileMetadataIncludesDimensions(): void {
+		$this->overrideConfigValue( MainConfigNames::ResponsiveImages, false );
+		$this->setService( 'RepoGroup', $this->newRepoGroupFindingFile() );
+
+		$html = $this->newFormatter()->format( new StringValue( 'Jonas-revenge.png' ) );
+
+		$this->assertStringContainsString( '800 × 600 pixels', $html );
+	}
+
+	private function newRepoGroupFindingFile(): RepoGroup {
+		$file = $this->createStub( File::class );
+		$file->method( 'transform' )->willReturn( $this->newThumbnail() );
+		$file->method( 'getDimensionsString' )->willReturn( '800 × 600 pixels' );
+		$file->method( 'getSize' )->willReturn( 12345 );
+
+		$repoGroup = $this->createStub( RepoGroup::class );
+		$repoGroup->method( 'findFile' )->willReturn( $file );
+
+		return $repoGroup;
+	}
+
+	private function newThumbnail(): object {
+		return new class {
+			public function toHtml(): string {
+				return '<img src="thumbnail.png">';
+			}
+		};
+	}
+
+	private function newFormatter(): InlineImageFormatter {
+		return new InlineImageFormatter(
+			ParserOptions::newFromAnon(),
+			[],
+			'en',
+			new LocalImageLinker(),
+			'commons-media-caption'
+		);
+	}
+
+}