Skip to content

Commit 79a24c4

Browse files
committed
Fix property mappings to use entity prefix instead of direct claim prefix
1 parent 25e6e1f commit 79a24c4

4 files changed

Lines changed: 2 additions & 50 deletions

File tree

src/Presentation/RDF/MappingRdfBuilder.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ class MappingRdfBuilder implements EntityRdfBuilder {
1717
public function __construct(
1818
private RdfWriter $writer,
1919
private MappingRepository $repository,
20-
private PropertyMappingPrefixBuilder $propertyMappingPrefixBuilder
20+
private string $rdfNodeNamespacePrefix
2121
) {
2222
}
2323

@@ -85,7 +85,7 @@ private function addItemMapping( Mapping $mapping ): void {
8585

8686
private function addPropertyMapping( Mapping $mapping, EntityId $entityId ): void {
8787
$this->writer
88-
->about( $this->propertyMappingPrefixBuilder->getPrefix(), $entityId->getSerialization() )
88+
->about( $this->rdfNodeNamespacePrefix, $entityId->getSerialization() )
8989
->a( 'owl', 'ObjectProperty' )
9090
->say( $mapping->getPredicateBase(), $mapping->getPredicateLocal() )
9191
->is( $mapping->object );

src/Presentation/RDF/PropertyMappingPrefixBuilder.php

Lines changed: 0 additions & 20 deletions
This file was deleted.

src/WikibaseRdfExtension.php

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
use ProfessionalWiki\WikibaseRDF\Presentation\RDF\MappingRdfBuilder;
3333
use ProfessionalWiki\WikibaseRDF\EntryPoints\Rest\GetMappingsApi;
3434
use ProfessionalWiki\WikibaseRDF\EntryPoints\Rest\SaveMappingsApi;
35-
use ProfessionalWiki\WikibaseRDF\Presentation\RDF\PropertyMappingPrefixBuilder;
3635
use ProfessionalWiki\WikibaseRDF\Presentation\RestSaveMappingsPresenter;
3736
use ProfessionalWiki\WikibaseRDF\Presentation\HtmlMappingsPresenter;
3837
use ValueValidators\ValueValidator;
@@ -91,12 +90,6 @@ public function newMappingRdfBuilder( RdfWriter $writer ): MappingRdfBuilder {
9190
return new MappingRdfBuilder(
9291
$writer,
9392
$this->newMappingRepository( RequestContext::getMain()->getUser() ),
94-
$this->newPropertyMappingPrefixBuilder()
95-
);
96-
}
97-
98-
private function newPropertyMappingPrefixBuilder(): PropertyMappingPrefixBuilder {
99-
return new PropertyMappingPrefixBuilder(
10093
WikibaseRepo::getLocalEntitySource()->getRdfNodeNamespacePrefix()
10194
);
10295
}

tests/Presentation/RDF/PropertyMappingPrefixBuilderTest.php

Lines changed: 0 additions & 21 deletions
This file was deleted.

0 commit comments

Comments
 (0)