Skip to content

Commit ea88d0b

Browse files
committed
Refactor: 예약 관련 DTO 수정 및 응답 관련 코드 수정
1 parent 06fd8f9 commit ea88d0b

File tree

4 files changed

+5
-6
lines changed

4 files changed

+5
-6
lines changed

src/main/java/com/ticketaka/performance/dto/ReservationDTO.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
@NoArgsConstructor
1616
public class ReservationDTO {
1717
private String memberId;
18-
private String memberEmail;
1918
private String performanceId;
2019
private int reservationTicketCount;
2120
private LocalDate reservationDate;
@@ -26,7 +25,6 @@ public class ReservationDTO {
2625
public ReservationDTO from(ReservationRequest request, int count, PrfSession prfSession) {
2726
return ReservationDTO.builder()
2827
.memberId(request.getMemberId())
29-
.memberEmail(request.getMemberEmail())
3028
.performanceId(request.getPerformanceId())
3129
.reservationTicketCount(count)
3230
.reservationDate(prfSession.getPrfSessionDate())

src/main/java/com/ticketaka/performance/dto/request/ReservationRequest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
@AllArgsConstructor
1212
public class ReservationRequest {
1313
private String memberId;
14-
private String memberEmail;
1514
private String performanceId;
1615
private String prfPoster;
1716
private int prfSessionId;

src/main/java/com/ticketaka/performance/feign/ReservationFeignClient.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,5 @@
1111
@FeignClient(name="FeignClient", url="${reservation.url}:"+"${reservation.port}", path = "/reservation")
1212
public interface ReservationFeignClient {
1313
@PostMapping("/create")
14-
ResponseEntity<String> createReservation(@RequestBody ReservationDTO reservationDTO);
14+
BaseResponse createReservation(@RequestBody ReservationDTO reservationDTO);
1515
}

src/main/java/com/ticketaka/performance/service/ReservationServiceImpl.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,10 @@
22

33
import com.ticketaka.performance.domain.PrfSession;
44
import com.ticketaka.performance.dto.ReservationDTO;
5+
import com.ticketaka.performance.dto.StatusCode;
56
import com.ticketaka.performance.dto.request.ReservationRequest;
67
import com.ticketaka.performance.dto.request.WaitingListRequest;
8+
import com.ticketaka.performance.dto.response.BaseResponse;
79
import com.ticketaka.performance.exception.CustomException;
810
import com.ticketaka.performance.exception.CustomException.NoCreationAvailableException;
911
import com.ticketaka.performance.exception.CustomException.NoVacancyFoundException;
@@ -76,9 +78,9 @@ public void makeReservation(ReservationRequest request) throws Exception {
7678

7779
PrfSession prfSession = prfSessionRMapCache.get(request.getPrfSessionId());
7880
ReservationDTO reservationDTO = new ReservationDTO().from(request, count, prfSession);
79-
ResponseEntity<String> response = reservationFeignClient.createReservation(reservationDTO);
81+
BaseResponse response = reservationFeignClient.createReservation(reservationDTO);
8082

81-
if(!Objects.equals(response.getBody(), "SUCCESS_RESERVATION")) {
83+
if(response.getCode() != StatusCode.OK.getCode()) {
8284
throw new ReservationFailedException();
8385
}
8486
prfSession.setRemainingSeat(count);

0 commit comments

Comments
 (0)