You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Per this test case in the PR, it looks like the CSS content is by default being automatically inlined, when it should really be doing it based on the setting chosen by the user as per the available configuration option
We should probably externalize anything that provides a supported import attribute.
should we also be doing more mergeResponse in rollup.config.js? Had to formally pass response.headers from PostCSS plugin, but maybe this was intentional for this specific use case?
The text was updated successfully, but these errors were encountered:
thescientist13
changed the title
CSS Import Attributes are not being externalized based on polyfill configuration settings
supported Import Attributes from node modules are not being externalized based on polyfill configuration settings
Dec 28, 2024
Type of Change
Bug
Summary
Observed in #1361 that although we are properly handling CSS based import attributes from node_modules, e.g.
Per this test case in the PR, it looks like the CSS content is by default being automatically inlined, when it should really be doing it based on the setting chosen by the user as per the available configuration option
Details
It seems to simply be a case that we only instruct Rollup to externalize in one place, when resolving IDs to see if they are in the user's workspace.
https://github.com/ProjectEvergreen/greenwood/blob/v0.31.0-alpha.1/packages/cli/src/config/rollup.config.js#L34
We should probably externalize anything that provides a supported import attribute.
The text was updated successfully, but these errors were encountered: