Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/issue 1375 preserve HTML entities when prerendering markdown #1376

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Jan 9, 2025

Related Issue

resolves #1375

Documentation

N / A

Summary of Changes

  1. Preserve HTML entities when prerendering markdown
  2. Test case to verify preservation of HTML entities when prerendering in markdown

TODO

  1. This should probably happen in plugin-standard-html
  2. validate against feature/issue 96 enhanced copy to clipboard with PNPM docs www.greenwoodjs.dev#120
  3. maybe there's an off chance this will help 🙏? - enhancement/rework of DOM shim (using parse5) to allow for element properties in the future wcc#178
    • holy moly, it did 💯 🤩
  4. Is this the best way to handle this? for instance, confirm there are no other prerendering plugins in use, to better isolate to just WCC usage?
  5. close out bug/preserve light dom html entities in text nodes wcc#182
  6. depends on enhancement/upgrade WCC v0.16.0 #1340 (one test case will fail until that happens)

@thescientist13 thescientist13 added bug Something isn't working question Further information is requested CLI labels Jan 9, 2025
@thescientist13 thescientist13 changed the title bug/issue 1375preserve HTML entities when prerendering markdown bug/issue 1375 preserve HTML entities when prerendering markdown Jan 9, 2025
@thescientist13 thescientist13 marked this pull request as ready for review January 9, 2025 18:49
@thescientist13 thescientist13 added SSR and removed question Further information is requested labels Jan 20, 2025
@thescientist13 thescientist13 force-pushed the bug/issue-1375-preserve-markdown-html-entities-wcc-prerendering branch from 93e601a to 6fa9e1b Compare January 21, 2025 01:48
@thescientist13 thescientist13 force-pushed the bug/issue-1375-preserve-markdown-html-entities-wcc-prerendering branch from 6fa9e1b to 8032f40 Compare January 23, 2025 16:24
@thescientist13 thescientist13 merged commit 7fd7dc3 into master Jan 23, 2025
10 checks passed
@thescientist13 thescientist13 deleted the bug/issue-1375-preserve-markdown-html-entities-wcc-prerendering branch January 23, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLI SSR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

escaped HTML entities in markdown content are not being honored when prerendering Light DOM HTML
1 participant