test coverage increase

Author: nishika26

backend/app/tests/services/collections/test_helpers.py

@@ -11,7 +11,13 @@
 from app.services.collections import helpers
 from app.tests.utils.utils import get_project
 from app.tests.utils.collection import get_vector_store_collection
-from app.services.collections.helpers import ensure_unique_name
+from app.services.collections.helpers import (
+    ensure_unique_name,
+    get_service_name,
+    to_collection_public,
+)
+from app.models import Collection, ProviderType
+from app.core.util import now
 
 
 def test_extract_error_message_parses_json_and_strips_prefix() -> None:
@@ -167,3 +173,109 @@ def test_ensure_unique_name_conflict_with_vector_store_collection(db: Session) -
 
     assert exc.value.status_code == 409
     assert "already exists" in exc.value.detail
+
+
+# get_service_name
+
+
+def test_get_service_name_openai() -> None:
+    """Test that OpenAI provider returns correct service name."""
+    result = get_service_name("openai")
+    assert result == "openai vector store"
+
+
+def test_get_service_name_case_insensitive() -> None:
+    """Test that provider name is case-insensitive."""
+    assert get_service_name("OpenAI") == "openai vector store"
+    assert get_service_name("OPENAI") == "openai vector store"
+    assert get_service_name("OpEnAi") == "openai vector store"
+
+
+def test_get_service_name_unknown_provider() -> None:
+    """Test that unknown providers return empty string."""
+    assert get_service_name("unknown") == ""
+    assert get_service_name("bedrock") == ""  # Commented out in the mapping
+    assert get_service_name("gemini") == ""  # Commented out in the mapping
+    assert get_service_name("") == ""
+
+
+# to_collection_public
+
+
+def test_to_collection_public_vector_store() -> None:
+    """Test conversion of vector store collection to public model."""
+    collection = Collection(
+        id=uuid4(),
+        project_id=1,
+        provider=ProviderType.openai,
+        llm_service_id="vs_123",
+        llm_service_name="openai vector store",  # Matches get_service_name("openai")
+        name="Test Collection",
+        description="Test description",
+        inserted_at=now(),
+        updated_at=now(),
+        deleted_at=None,
+    )
+
+    result = to_collection_public(collection)
+
+    # For vector store, should map to knowledge_base fields
+    assert result.id == collection.id
+    assert result.knowledge_base_id == "vs_123"
+    assert result.knowledge_base_provider == "openai vector store"
+    assert result.llm_service_id is None
+    assert result.llm_service_name is None
+    assert result.project_id == 1
+    assert result.inserted_at == collection.inserted_at
+    assert result.updated_at == collection.updated_at
+    assert result.deleted_at is None
+
+
+def test_to_collection_public_assistant() -> None:
+    """Test conversion of assistant collection to public model."""
+    collection = Collection(
+        id=uuid4(),
+        project_id=2,
+        provider=ProviderType.openai,
+        llm_service_id="asst_456",
+        llm_service_name="gpt-4",  # Does NOT match vector store name
+        name="Assistant Collection",
+        description="Assistant description",
+        inserted_at=now(),
+        updated_at=now(),
+        deleted_at=None,
+    )
+
+    result = to_collection_public(collection)
+
+    # For assistant, should map to llm_service fields
+    assert result.id == collection.id
+    assert result.llm_service_id == "asst_456"
+    assert result.llm_service_name == "gpt-4"
+    assert result.knowledge_base_id is None
+    assert result.knowledge_base_provider is None
+    assert result.project_id == 2
+    assert result.inserted_at == collection.inserted_at
+    assert result.updated_at == collection.updated_at
+    assert result.deleted_at is None
+
+
+def test_to_collection_public_with_deleted_at() -> None:
+    """Test that deleted_at field is properly included when set."""
+    deleted_time = now()
+    collection = Collection(
+        id=uuid4(),
+        project_id=3,
+        provider=ProviderType.openai,
+        llm_service_id="vs_789",
+        llm_service_name="openai vector store",
+        name="Deleted Collection",
+        description="Deleted",
+        inserted_at=now(),
+        updated_at=now(),
+        deleted_at=deleted_time,
+    )
+
+    result = to_collection_public(collection)
+
+    assert result.deleted_at == deleted_time