resolved comments

Author: rkritika1508

backend/app/crud/banlist.py

@@ -1,4 +1,3 @@
-from datetime import datetime
 from typing import List, Optional
 from uuid import UUID
 
@@ -10,8 +9,9 @@
 from app.schemas.banlist import BanListCreate, BanListUpdate
 from app.utils import now
 
+
 class BanListCrud:
-    def create(     
+    def create(
         self,
         session: Session,
         data: BanListCreate,
@@ -41,8 +41,8 @@ def create(
         return obj
 
     def get(
-        self, 
-        session: Session, 
+        self,
+        session: Session,
         id: UUID,
         organization_id: int,
         project_id: int
@@ -114,16 +114,17 @@ def delete(self, session: Session, obj: BanList):
             session.rollback()
             raise
 
-def check_owner(self, obj, organization_id, project_id):
-    is_owner = (
-        obj.organization_id == organization_id
-        and obj.project_id == project_id
-    )
-
-    if not is_owner:
-        raise HTTPException(
-            status_code=403,
-            detail="You do not have permission to access this resource."
+    def check_owner(self, obj: BanList, organization_id: int, project_id: int) -> None:
+        is_owner = (
+            obj.organization_id == organization_id
+            and obj.project_id == project_id
         )
 
-banlist_crud = BanListCrud()
+        if not is_owner:
+            raise HTTPException(
+                status_code=403,
+                detail="You do not have permission to access this resource."
+            )
+
+
+banlist_crud = BanListCrud()

backend/app/tests/conftest.py

@@ -96,6 +96,21 @@ def seed_db():
         seed_test_data(session)
         yield
 
+@pytest.fixture
+def clear_database():
+    """Clear key config tables before and after each test."""
+    with Session(test_engine) as session:
+        session.exec(delete(BanList))
+        session.exec(delete(ValidatorConfig))
+        session.commit()
+
+    yield
+
+    with Session(test_engine) as session:
+        session.exec(delete(BanList))
+        session.exec(delete(ValidatorConfig))
+        session.commit()
+
 @pytest.fixture(scope="function")
 def client():
     with TestClient(app) as c:

backend/app/tests/test_banlists_integration.py

@@ -1,9 +1,5 @@
 import uuid
 import pytest
-from sqlmodel import Session, delete
-
-from app.core.db import engine
-from app.models.config.banlist import BanList
 from app.tests.seed_data import (
     BANLIST_INTEGRATION_ORGANIZATION_ID,
     BANLIST_INTEGRATION_PROJECT_ID,
@@ -20,19 +16,6 @@
 )
 
 
-@pytest.fixture
-def clear_database():
-    with Session(engine) as session:
-        session.exec(delete(BanList))
-        session.commit()
-
-    yield
-
-    with Session(engine) as session:
-        session.exec(delete(BanList))
-        session.commit()
-
-
 class BaseBanListTest:
 
     def create(self, client, payload_key="minimal", **kwargs):

backend/app/tests/test_validator_configs_integration.py

@@ -1,10 +1,6 @@
 import uuid
 
 import pytest
-from sqlmodel import Session, delete
-
-from app.core.db import engine
-from app.models.config.validator_config import ValidatorConfig
 from app.tests.seed_data import (
     VALIDATOR_INTEGRATION_ORGANIZATION_ID,
     VALIDATOR_INTEGRATION_PROJECT_ID,
@@ -20,20 +16,6 @@
 )
 
 
-@pytest.fixture
-def clear_database():
-    """Clear ValidatorConfig table before and after each test."""
-    with Session(engine) as session:
-        session.exec(delete(ValidatorConfig))
-        session.commit()
-
-    yield
-
-    with Session(engine) as session:
-        session.exec(delete(ValidatorConfig))
-        session.commit()
-
-
 class BaseValidatorTest:
     """Base class with helper methods for validator tests."""