Skip to content

Commit 07f67ab

Browse files
authored
Merge pull request #4374 from ProvableHQ/downgrade_duplicate_cert_log_level
Only error on DAG certificate replacement when the ID differs
2 parents b702aaa + 3b5c037 commit 07f67ab

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

node/bft/src/helpers/dag.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,10 @@ impl<N: Network> DAG<N> {
116116
// If a previous certificate existed for the author, log it.
117117
match previous {
118118
None => trace!("Added new certificate for round {round} by author {author} to the DAG"),
119+
// Re-inserting the same certificate is a no-op from a consensus perspective.
120+
Some(previous) if previous.id() == certificate_id => {
121+
trace!("Certificate for round {round} by author {author} already existed in the DAG");
122+
}
119123
// A second certificate for one author in a round means the author equivocated. The
120124
// DAG keeps whichever arrived last, so validators that saw both may now disagree.
121125
Some(previous) => error!(

0 commit comments

Comments
 (0)