fix: add missing #[source]/#[from] to error variants wrapping inner errors

Group A — replace trivial manual `From` impls with `#[from]`:
- `SynthesisError::IoError`: add `#[from]`, delete manual `From<std::io::Error>` impl
- `AHPError::ConstraintSystemError`: add `#[from]`, delete manual `From<SynthesisError>` impl
- `GroupError::FieldError`: add `#[from]`, delete manual `From<FieldError>` impl

Group B — add `#[source]` to named-field variants in `CheckBlockError`:
- `InvalidPrefix`: add `#[source]` on `error` field, fix typo ("as" → "has"),
  remove `{error:?}` interpolation
- `SpeculationFailed`: add `#[source]` on `inner`, remove `{inner}` interpolation
- `VerificationFailed`: add `#[source]` on `inner`, remove `{inner}` interpolation

Format strings no longer interpolate `#[source]` fields, avoiding the
duplication bug fixed in the prior commit. The inner errors remain
accessible via `Error::source()`, enabling proper error chain traversal.

Author: mitchmindtree

algorithms/src/r1cs/errors.rs

@@ -40,18 +40,12 @@ pub enum SynthesisError {
     #[error("Encountered an identity element in the CRS")]
     UnexpectedIdentity,
     /// During proof generation, we encountered an I/O error with the CRS
-    #[error("Encountered an I/O error")]
-    IoError(std::io::Error),
+    #[error("I/O error")]
+    IoError(#[from] std::io::Error),
     /// During verification, our verifying key was malformed.
     #[error("Malformed verifying key, public input count was {} but expected {}", _0, _1)]
     MalformedVerifyingKey(usize, usize),
     /// During CRS generation, we observed an unconstrained auxiliary variable
     #[error("Auxiliary variable was unconstrained")]
     UnconstrainedVariable,
 }
-
-impl From<std::io::Error> for SynthesisError {
-    fn from(e: std::io::Error) -> SynthesisError {
-        SynthesisError::IoError(e)
-    }
-}

algorithms/src/snark/varuna/ahp/errors.rs

@@ -22,8 +22,8 @@ pub enum AHPError {
     #[error("Batch size was zero; must be at least 1.")]
     BatchSizeIsZero,
 
-    #[error("An error occurred during constraint generation.")]
-    ConstraintSystemError(crate::r1cs::errors::SynthesisError),
+    #[error("constraint generation error")]
+    ConstraintSystemError(#[from] crate::r1cs::errors::SynthesisError),
 
     #[error("The instance generated during proving does not match that in the index.")]
     InstanceDoesNotMatchIndex,
@@ -40,9 +40,3 @@ pub enum AHPError {
     #[error("During synthesis, our polynomials ended up being too high of degree.")]
     PolyTooLarge,
 }
-
-impl From<crate::r1cs::errors::SynthesisError> for AHPError {
-    fn from(other: crate::r1cs::errors::SynthesisError) -> Self {
-        AHPError::ConstraintSystemError(other)
-    }
-}

curves/src/errors.rs

@@ -18,8 +18,8 @@ pub enum GroupError {
     #[error("{}: {}", _0, _1)]
     Crate(&'static str, String),
 
-    #[error("{}", _0)]
-    FieldError(snarkvm_fields::FieldError),
+    #[error("field error")]
+    FieldError(#[from] snarkvm_fields::FieldError),
 
     #[error("Invalid group element")]
     InvalidGroupElement,
@@ -37,12 +37,6 @@ pub enum GroupError {
     ParsingNonDigitCharacter,
 }
 
-impl From<snarkvm_fields::FieldError> for GroupError {
-    fn from(error: snarkvm_fields::FieldError) -> Self {
-        GroupError::FieldError(error)
-    }
-}
-
 impl From<std::io::Error> for GroupError {
     fn from(error: std::io::Error) -> Self {
         GroupError::Crate("std::io", format!("{error:?}"))

ledger/src/check_next_block.rs

@@ -54,14 +54,20 @@ pub enum CheckBlockError<N: Network> {
     #[error("Block has invalid hash")]
     InvalidHash,
     /// An error related to the given prefix of pending blocks.
-    #[error("The prefix as an error at index {index} - {error:?}")]
+    #[error("The prefix has an error at index {index}")]
     InvalidPrefix { index: usize, error: Box<CheckBlockError<N>> },
     #[error("The block contains solution '{solution_id}', but it already exists in the ledger")]
     SolutionAlreadyExists { solution_id: SolutionID<N> },
-    #[error("Failed to speculate over unconfirmed transactions - {inner}")]
-    SpeculationFailed { inner: anyhow::Error },
-    #[error("Failed to verify block - {inner}")]
-    VerificationFailed { inner: anyhow::Error },
+    #[error("Failed to speculate over unconfirmed transactions")]
+    SpeculationFailed {
+        #[source]
+        inner: anyhow::Error,
+    },
+    #[error("Failed to verify block")]
+    VerificationFailed {
+        #[source]
+        inner: anyhow::Error,
+    },
     #[error("Prover '{prover_address}' has reached their solution limit for the current epoch")]
     SolutionLimitReached { prover_address: Address<N> },
     #[error("The previous block should contain solution '{solution_id}', but it does not exist in the ledger")]