Expand test suite

[ddundo]

The test suite is really minimal at the moment. We could also turn existing demo notebooks into tests.

[ddundo]

And all 3 tests in test_oggm_compat.py fail with the same error, e.g.,

    def test_random_mb_run():
    
        rid = 'RGI60-15.03473'
>       gdir = oggm_compat.single_flowline_glacier_directory(rid, prepro_border=80)

test_oggm_compat.py:45: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

rgi_id = 'RGI60-15.03473', reset = False, prepro_border = 80, logging_level = 'WORKFLOW', has_internet = True, working_dir = '/home/ubuntu/PyGEM/sample_data/sample_data///oggm_gdirs/'

    def single_flowline_glacier_directory(rgi_id, reset=pygem_prms['oggm']['overwrite_gdirs'], prepro_border=pygem_prms['oggm']['border'],
                                          logging_level= pygem_prms['oggm']['logging_level'], has_internet= pygem_prms['oggm']['has_internet'],
                                          working_dir=f"{pygem_prms['root']}/{pygem_prms['oggm']['oggm_gdir_relpath']}"):
        """Prepare a GlacierDirectory for PyGEM (single flowline to start with)
    
        Parameters
        ----------
        rgi_id : str
            the rgi id of the glacier (RGIv60-)
        reset : bool
            set to true to delete any pre-existing files. If false (the default),
            the directory won't be re-downloaded if already available locally in
            order to spare time.
        prepro_border : int
            the size of the glacier map: 10, 80, 160, 240
    
        Returns
        -------
        a GlacierDirectory object
        """
        if type(rgi_id) != str:
            raise ValueError('We expect rgi_id to be a string')
        if rgi_id.startswith('RGI60-') == False:
            rgi_id = 'RGI60-' + rgi_id.split('.')[0].zfill(2) + '.' + rgi_id.split('.')[1]
        else:
>           raise ValueError('Check RGIId is correct')
E           ValueError: Check RGIId is correct

../oggm_compat.py:58: ValueError

[btobers]

See PR #78 and PyGEM-notebooks PR #12, which together will enable the advanced_test_tw.ipynb notebook to be included as a test.

[btobers]

The test suite has been expanded significantly with PR #147, PR #137, and others. We can add to it add to the test suite as we develop further, but for now the tests are pretty robust.