Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use of install_aliases in libraries (as opposed to applications)? #236

Open
simon-weber opened this issue Sep 2, 2016 · 0 comments
Open

Comments

@simon-weber
Copy link

We've run into an interesting situation. gmusicapi, which is a library, is used by applications such as mopidy-gmusic. For gmusicapi to have 2/3 compatibility, we use python-future and install_aliases.

Now, it looks like install_aliases has the potential to cause problems for code that doesn't expect it. In our case, due to mopidy-gmusic's non-future compatibility layer, they're getting new types in places they don't expect (details/recreate steps in simon-weber/gmusicapi#493 (comment)).

So, my question: should libraries avoid the use of install_aliases for this reason? Or is that considered safe, meaning we should look elsewhere (eg at the behavior of future's intern(bytes()))?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants