Merge zsa1 into Swaps branch
#1017
ci.yml
on: pull_request
Matrix: build-latest
Matrix: build-nodefault
Matrix: check-msrv
Matrix: required-test
Bitrot check
1m 39s
Clippy (MSRV)
2m 10s
Intra-doc links
1m 7s
Rustfmt
14s
protobuf consistency
1m 5s
UUID validity
5s
Clippy (beta)
1m 49s
Matrix: build-nostd
Matrix: test-slow
Matrix: test
Required status checks have passed
3s
Annotations
6 errors, 44 warnings, and 7 notices
|
Test NU7 on Linux
Process completed with exit code 101.
|
|
Test all-features on Linux
The strategy configuration was canceled because "required-test.Linux_NU7" failed
|
|
Test all-features on Linux
The operation was canceled.
|
|
Required status checks have passed
Process completed with exit code 1.
|
|
Slow Test NU7 on Linux
Process completed with exit code 101.
|
|
Test NU7 on Windows
Process completed with exit code 1.
|
|
Check ZFuture build on macOS
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: Swatinem/rust-cache@779680da715d629ac1d338a641029a2f4372abb5. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Check ZFuture build on Linux
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: Swatinem/rust-cache@779680da715d629ac1d338a641029a2f4372abb5. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Check ZFuture-allfeatures build on Linux
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: Swatinem/rust-cache@779680da715d629ac1d338a641029a2f4372abb5. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Clippy (beta)
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: auguwu/clippy-action@94a9ff2f6920180b89e5c03d121d0af04a9d3e03. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
iterating on a map's values:
zcash_client_memory/src/lib.rs#L519
warning: iterating on a map's values
--> zcash_client_memory/src/types/memory_wallet/mod.rs:519:12
|
519 | Ok(self
| ____________^
520 | | .accounts
521 | | .iter()
522 | | .filter_map(|(_, a)| match a.source() {
... |
530 | | _ => None,
531 | | })
| |______________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/beta/index.html#iter_kv_map
= note: `-W clippy::iter-kv-map` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::iter_kv_map)]`
help: try
|
519 ~ Ok(self
520 + .accounts.values().filter_map(|a| match a.source() {
521 + AccountSource::Derived { derivation, .. } => {
522 + if derivation.seed_fingerprint() == seed_fingerprint {
523 + Some(derivation.account_index())
524 + } else {
525 + None
526 + }
527 + }
528 + _ => None,
529 + })
|
|
|
you seem to want to iterate on a map's values:
zcash_client_memory/src/lib.rs#L185
warning: you seem to want to iterate on a map's values
--> zcash_client_memory/src/types/account.rs:185:29
|
185 | for (_, account) in self.accounts.iter_mut() {
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/beta/index.html#for_kv_map
= note: `-W clippy::for-kv-map` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::for_kv_map)]`
help: use the corresponding method
|
185 - for (_, account) in self.accounts.iter_mut() {
185 + for account in self.accounts.values_mut() {
|
|
|
consider using `sort_by_key`:
zcash_client_memory/src/lib.rs#L285
warning: consider using `sort_by_key`
--> zcash_client_memory/src/input_source.rs:285:9
|
285 | eligible_notes.sort_by(|a, b| a.commitment_tree_position.cmp(&b.commitment_tree_position));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/beta/index.html#unnecessary_sort_by
= note: `-W clippy::unnecessary-sort-by` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::unnecessary_sort_by)]`
help: try
|
285 - eligible_notes.sort_by(|a, b| a.commitment_tree_position.cmp(&b.commitment_tree_position));
285 + eligible_notes.sort_by_key(|a| a.commitment_tree_position);
|
|
|
this pattern is unneeded as the `..` pattern can match that element:
zcash_client_memory/src/lib.rs#L83
warning: this pattern is unneeded as the `..` pattern can match that element
--> zcash_client_memory/src/wallet_read.rs:83:43
|
83 | AccountSource::Imported { purpose: _, .. } => None,
| ^^^^^^^^^^^^ help: remove it
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/beta/index.html#unneeded_wildcard_pattern
= note: `-W clippy::unneeded-wildcard-pattern` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::unneeded_wildcard_pattern)]`
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
zcash_client_backend/src/lib.rs#L176
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> zcash_client_backend/src/fees.rs:176:20
|
176 | .chain(Some(fee_required).into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/b2282dd5646a57d570fc86fbe8df0e8826665ef6/library/core/src/iter/traits/iterator.rs:513:11
= help: for further information visit https://rust-lang.github.io/rust-clippy/beta/index.html#useless_conversion
= note: `-W clippy::useless-conversion` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::useless_conversion)]`
help: consider removing the `.into_iter()`
|
176 - .chain(Some(fee_required).into_iter())
176 + .chain(Some(fee_required))
|
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
pczt/src/lib.rs#L282
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> pczt/src/transparent.rs:282:55
|
282 | for (lhs, rhs) in self.outputs.iter_mut().zip(outputs.into_iter()) {
| ^^^^^^^^^^^^^^^^^^^
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/b2282dd5646a57d570fc86fbe8df0e8826665ef6/library/core/src/iter/traits/iterator.rs:632:11
= help: for further information visit https://rust-lang.github.io/rust-clippy/beta/index.html#useless_conversion
help: consider removing the `.into_iter()`
|
282 - for (lhs, rhs) in self.outputs.iter_mut().zip(outputs.into_iter()) {
282 + for (lhs, rhs) in self.outputs.iter_mut().zip(outputs) {
|
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
pczt/src/lib.rs#L231
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> pczt/src/transparent.rs:231:54
|
231 | for (lhs, rhs) in self.inputs.iter_mut().zip(inputs.into_iter()) {
| ^^^^^^^^^^^^^^^^^^
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/b2282dd5646a57d570fc86fbe8df0e8826665ef6/library/core/src/iter/traits/iterator.rs:632:11
= help: for further information visit https://rust-lang.github.io/rust-clippy/beta/index.html#useless_conversion
help: consider removing the `.into_iter()`
|
231 - for (lhs, rhs) in self.inputs.iter_mut().zip(inputs.into_iter()) {
231 + for (lhs, rhs) in self.inputs.iter_mut().zip(inputs) {
|
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
pczt/src/lib.rs#L401
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> pczt/src/sapling.rs:401:55
|
401 | for (lhs, rhs) in self.outputs.iter_mut().zip(outputs.into_iter()) {
| ^^^^^^^^^^^^^^^^^^^
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/b2282dd5646a57d570fc86fbe8df0e8826665ef6/library/core/src/iter/traits/iterator.rs:632:11
= help: for further information visit https://rust-lang.github.io/rust-clippy/beta/index.html#useless_conversion
help: consider removing the `.into_iter()`
|
401 - for (lhs, rhs) in self.outputs.iter_mut().zip(outputs.into_iter()) {
401 + for (lhs, rhs) in self.outputs.iter_mut().zip(outputs) {
|
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
pczt/src/lib.rs#L358
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> pczt/src/sapling.rs:358:54
|
358 | for (lhs, rhs) in self.spends.iter_mut().zip(spends.into_iter()) {
| ^^^^^^^^^^^^^^^^^^
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/b2282dd5646a57d570fc86fbe8df0e8826665ef6/library/core/src/iter/traits/iterator.rs:632:11
= help: for further information visit https://rust-lang.github.io/rust-clippy/beta/index.html#useless_conversion
help: consider removing the `.into_iter()`
|
358 - for (lhs, rhs) in self.spends.iter_mut().zip(spends.into_iter()) {
358 + for (lhs, rhs) in self.spends.iter_mut().zip(spends) {
|
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
pczt/src/lib.rs#L330
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> pczt/src/orchard.rs:330:55
|
330 | for (lhs, rhs) in self.actions.iter_mut().zip(actions.into_iter()) {
| ^^^^^^^^^^^^^^^^^^^
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/b2282dd5646a57d570fc86fbe8df0e8826665ef6/library/core/src/iter/traits/iterator.rs:632:11
= help: for further information visit https://rust-lang.github.io/rust-clippy/beta/index.html#useless_conversion
= note: `-W clippy::useless-conversion` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::useless_conversion)]`
help: consider removing the `.into_iter()`
|
330 - for (lhs, rhs) in self.actions.iter_mut().zip(actions.into_iter()) {
330 + for (lhs, rhs) in self.actions.iter_mut().zip(actions) {
|
|
|
Clippy (MSRV)
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: auguwu/clippy-action@94a9ff2f6920180b89e5c03d121d0af04a9d3e03. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Latest build on ubuntu-latest
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: Swatinem/rust-cache@779680da715d629ac1d338a641029a2f4372abb5. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Latest build on macOS-latest
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: Swatinem/rust-cache@779680da715d629ac1d338a641029a2f4372abb5. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Check ZFuture-allfeatures build on macOS
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: Swatinem/rust-cache@779680da715d629ac1d338a641029a2f4372abb5. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Check ZFuture build on Windows
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: Swatinem/rust-cache@779680da715d629ac1d338a641029a2f4372abb5. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Check ZFuture-allfeatures build on Windows
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: Swatinem/rust-cache@779680da715d629ac1d338a641029a2f4372abb5. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Latest build on windows-latest
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: Swatinem/rust-cache@779680da715d629ac1d338a641029a2f4372abb5. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Test transparent-key-encoding-only on Linux
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: Swatinem/rust-cache@779680da715d629ac1d338a641029a2f4372abb5. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Test Sapling-only on Linux
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: Swatinem/rust-cache@779680da715d629ac1d338a641029a2f4372abb5. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Test Orchard on Linux
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: Swatinem/rust-cache@779680da715d629ac1d338a641029a2f4372abb5. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Slow Test transparent on Linux
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: Swatinem/rust-cache@779680da715d629ac1d338a641029a2f4372abb5. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Slow Test Sapling-only on Linux
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: Swatinem/rust-cache@779680da715d629ac1d338a641029a2f4372abb5. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Test Sapling-only on macOS
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: Swatinem/rust-cache@779680da715d629ac1d338a641029a2f4372abb5. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Test transparent-inputs-only on Linux
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: Swatinem/rust-cache@779680da715d629ac1d338a641029a2f4372abb5. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Test transparent on Linux
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: Swatinem/rust-cache@779680da715d629ac1d338a641029a2f4372abb5. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Test Orchard on macOS
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: Swatinem/rust-cache@779680da715d629ac1d338a641029a2f4372abb5. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Test transparent on macOS
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: Swatinem/rust-cache@779680da715d629ac1d338a641029a2f4372abb5. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Slow Test Orchard on Linux
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: Swatinem/rust-cache@779680da715d629ac1d338a641029a2f4372abb5. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Slow Test all-features on Linux
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: Swatinem/rust-cache@779680da715d629ac1d338a641029a2f4372abb5. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Test all-pools on Linux
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: Swatinem/rust-cache@779680da715d629ac1d338a641029a2f4372abb5. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Test all-pools on macOS
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: Swatinem/rust-cache@779680da715d629ac1d338a641029a2f4372abb5. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Test Sapling-only on Windows
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: Swatinem/rust-cache@779680da715d629ac1d338a641029a2f4372abb5. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Test NU7 on Linux
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: Swatinem/rust-cache@779680da715d629ac1d338a641029a2f4372abb5. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Test all-features on Linux
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: Swatinem/rust-cache@779680da715d629ac1d338a641029a2f4372abb5. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Test transparent on Windows
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: Swatinem/rust-cache@779680da715d629ac1d338a641029a2f4372abb5. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Slow Test NU7 on Linux
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: Swatinem/rust-cache@779680da715d629ac1d338a641029a2f4372abb5. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Test Orchard on Windows
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: Swatinem/rust-cache@779680da715d629ac1d338a641029a2f4372abb5. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Test all-pools on Windows
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: Swatinem/rust-cache@779680da715d629ac1d338a641029a2f4372abb5. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Test NU7 on Windows
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: Swatinem/rust-cache@779680da715d629ac1d338a641029a2f4372abb5. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Test all-features on Windows
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: Swatinem/rust-cache@779680da715d629ac1d338a641029a2f4372abb5. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Check ZFuture build on macOS
The macos-latest label will migrate to macOS 26 beginning June 15, 2026. For more information see https://github.com/actions/runner-images/issues/14167
|
|
Latest build on macOS-latest
The macos-latest label will migrate to macOS 26 beginning June 15, 2026. For more information see https://github.com/actions/runner-images/issues/14167
|
|
Check ZFuture-allfeatures build on macOS
The macos-latest label will migrate to macOS 26 beginning June 15, 2026. For more information see https://github.com/actions/runner-images/issues/14167
|
|
Test Sapling-only on macOS
The macos-latest label will migrate to macOS 26 beginning June 15, 2026. For more information see https://github.com/actions/runner-images/issues/14167
|
|
Test Orchard on macOS
The macos-latest label will migrate to macOS 26 beginning June 15, 2026. For more information see https://github.com/actions/runner-images/issues/14167
|
|
Test transparent on macOS
The macos-latest label will migrate to macOS 26 beginning June 15, 2026. For more information see https://github.com/actions/runner-images/issues/14167
|
|
Test all-pools on macOS
The macos-latest label will migrate to macOS 26 beginning June 15, 2026. For more information see https://github.com/actions/runner-images/issues/14167
|