Skip to content

Commit 93773e6

Browse files
committed
Add an input to select variable name in metadataform
1 parent 694e227 commit 93773e6

File tree

2 files changed

+15
-4
lines changed

2 files changed

+15
-4
lines changed

schema/metadata-form.json

+4
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,10 @@
1919
"title": "-"
2020
}
2121
]
22+
},
23+
"/sql-cell/variable": {
24+
"title": "Variable",
25+
"type": "string"
2226
}
2327
}
2428
},

src/index.ts

+11-4
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,13 @@ const plugin: JupyterFrontEndPlugin<void> = {
9393
body: JSON.stringify({ query: source, id: database_id })
9494
})
9595
.then(data => {
96-
if (kernel && injection.status) {
97-
const future = Private.transferDataToKernel(kernel, data.data);
96+
const variable = SqlCell.getMetadata(activeCell.model, 'variable');
97+
if (kernel && injection.status && variable) {
98+
const future = Private.transferDataToKernel(
99+
kernel,
100+
data.data,
101+
variable
102+
);
98103
future.done.then(reply => {
99104
console.log('REPLY', reply);
100105
});
@@ -394,13 +399,15 @@ namespace Private {
394399
*/
395400
export function transferDataToKernel(
396401
kernel: Kernel.IKernelConnection,
397-
data: any
402+
data: any,
403+
variable?: string
398404
): Kernel.IShellFuture<
399405
KernelMessage.IExecuteRequestMsg,
400406
KernelMessage.IExecuteReplyMsg
401407
> {
402408
data = JSON.stringify(data).replace(/"/gi, '\\"');
403-
const code = `_sql_transfer_data("${data}")`;
409+
const variableStr = variable ? `, "${variable}"` : '';
410+
const code = `_sql_transfer_data("${data}"${variableStr})`;
404411
const content: KernelMessage.IExecuteRequestMsg['content'] = {
405412
code: code,
406413
stop_on_error: true

0 commit comments

Comments
 (0)