Skip to content

Commit 1e9150e

Browse files
committed
Use value instead
1 parent d9efbfa commit 1e9150e

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

tests/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ set(test_target "test_sparrow_ipc_lib")
77
set(
88
SPARROW_IPC_TESTS_SRC
99
include/sparrow_ipc_tests_helpers.hpp
10-
# TODO move all these below under src?
10+
# TODO move all the files below under src?
1111
main.cpp
1212
test_utils.cpp
1313
test_primitive_array_serialization.cpp

tests/include/sparrow_ipc_tests_helpers.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ namespace sparrow_ipc
1717
}
1818

1919
CHECK(arr2.metadata().has_value());
20-
sp::key_value_view kvs1_view = *(arr1.metadata()); // TODO use value() instead
21-
sp::key_value_view kvs2_view = *(arr2.metadata());
20+
sp::key_value_view kvs1_view = arr1.metadata().value();
21+
sp::key_value_view kvs2_view = arr2.metadata().value();
2222

2323
CHECK_EQ(kvs1_view.size(), kvs2_view.size());
2424
auto kvs1_it = kvs1_view.cbegin();

0 commit comments

Comments
 (0)