Update to eigen 5.0.0 (#2040)

Author: cqc-alec

.github/workflows/build-without-conan.yml

@@ -52,10 +52,10 @@ jobs:
     - name: Install eigen
       run: |
         cd ${TMP_DIR}
-        wget https://gitlab.com/libeigen/eigen/-/archive/3.4.0/eigen-3.4.0.tar.bz2
-        bzip2 -dk eigen-3.4.0.tar.bz2
-        tar xvf eigen-3.4.0.tar
-        cd eigen-3.4.0/
+        wget https://gitlab.com/libeigen/eigen/-/archive/5.0.0/eigen-5.0.0.tar.bz2
+        bzip2 -dk eigen-5.0.0.tar.bz2
+        tar xvf eigen-5.0.0.tar
+        cd eigen-5.0.0/
         mkdir build
         cd build
         cmake -GNinja -DCMAKE_INSTALL_PREFIX=${INSTALL_DIR} ..

TKET_VERSION

@@ -1 +1 @@
-2.1.53
+2.1.54

build-without-conan.md

@@ -63,10 +63,10 @@ cmake --install .
 
 ```
 cd ${TMP_DIR}
-wget https://gitlab.com/libeigen/eigen/-/archive/3.4.0/eigen-3.4.0.tar.bz2
-bzip2 -dk eigen-3.4.0.tar.bz2
-tar xvf eigen-3.4.0.tar
-cd eigen-3.4.0/
+wget https://gitlab.com/libeigen/eigen/-/archive/5.0.0/eigen-5.0.0.tar.bz2
+bzip2 -dk eigen-5.0.0.tar.bz2
+tar xvf eigen-5.0.0.tar
+cd eigen-5.0.0/
 mkdir build
 cd build
 cmake -DCMAKE_INSTALL_PREFIX=${INSTALL_DIR} ..

tket/conanfile.py

@@ -59,8 +59,6 @@ def config_options(self):
             del self.options.fPIC
 
     def configure(self):
-        # Disable features that are still under the LGPL.
-        self.options["eigen"].MPL2_only = True
         # Only need header libraries from boost.
         self.options["boost"].header_only = True
 
@@ -142,7 +140,7 @@ def requirements(self):
         # libraries installed from remote:
         # https://quantinuumsw.jfrog.io/artifactory/api/conan/tket1-libs
         self.requires("boost/tci-1.89.0@tket/stable", transitive_headers=True)
-        self.requires("eigen/3.4.0", transitive_headers=True)
+        self.requires("eigen/5.0.0", transitive_headers=True)
         self.requires("nlohmann_json/3.12.0", transitive_headers=True)
         self.requires("symengine/tci-0.14.0.2@tket/stable", transitive_headers=True)
         self.requires("tkassert/0.3.4@tket/stable", transitive_headers=True)

tket/src/Circuit/CircUtils.cpp

@@ -838,7 +838,6 @@ static Circuit with_controls_symbolic(const Circuit &c, unsigned n_controls) {
 // Return the target unitary given a Cn* gate where n >= 0
 static Eigen::Matrix2cd get_target_op_matrix(const Op_ptr &op) {
   OpType optype = op->get_type();
-  Eigen::Matrix2cd m;
   switch (optype) {
     case OpType::CX:
     case OpType::CCX:

tket/src/Clifford/SymplecticTableau.cpp

@@ -384,8 +384,12 @@ SymplecticTableau SymplecticTableau::conjugate() const {
 
 void SymplecticTableau::gaussian_form() {
   MatrixXb fullmat = MatrixXb::Zero(get_n_rows(), 2 * get_n_qubits());
-  fullmat(Eigen::all, Eigen::seq(0, Eigen::last, 2)) = xmat;
-  fullmat(Eigen::all, Eigen::seq(1, Eigen::last, 2)) = zmat;
+  fullmat(
+      Eigen::placeholders::all, Eigen::seq(0, Eigen::placeholders::last, 2)) =
+      xmat;
+  fullmat(
+      Eigen::placeholders::all, Eigen::seq(1, Eigen::placeholders::last, 2)) =
+      zmat;
   std::vector<std::pair<unsigned, unsigned>> row_ops =
       gaussian_elimination_row_ops(fullmat);
   for (const std::pair<unsigned, unsigned> &op : row_ops) {