Add FastSignal as an alternative/replacement to GoodSignal #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasmz-dev
changed the title
|
I am not really able to test things here out, I am not really in Roblox development and can't be anymore properly due to Roblox's decision to not support Linux :(, just noticed this issue and wanted to note to it. Therefore, the changes made here are minor so that there aren't any issues I can't debug and such. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FastSignal when referred here is not the alternative provided to GoodSignal by their own post. This is a library I made; It isn't actually as speed focused as GoodSignal, despite the name, I've been thinking of changing it to BetterSignal but that just sounds problematic... Anyhow..
This implements a proposed solution at solving #463.
This pull request has as its objective:
This could actually replace both, the Signal.lua implementation, and GoodSignal, but at this time I'm only adding it as an alternative, I am open to changing this on how it is decided to implement this.
Need review:
Fixes #463