make Command implementations singletons

Author: supersaiyansubtlety

enigma-cli/src/main/java/org/quiltmc/enigma/command/CheckMappingsCommand.java

@@ -11,7 +11,9 @@
 import java.util.stream.Collectors;
 
 public final class CheckMappingsCommand extends Command {
-	public CheckMappingsCommand() {
+	public static final CheckMappingsCommand INSTANCE = new CheckMappingsCommand();
+
+	private CheckMappingsCommand() {
 		super(CommonArguments.INPUT_JAR, CommonArguments.INPUT_MAPPINGS);
 	}
 

enigma-cli/src/main/java/org/quiltmc/enigma/command/ComposeMappingsCommand.java

@@ -30,7 +30,9 @@ public final class ComposeMappingsCommand extends Command {
 					Which mappings should overwrite the others when composing conflicting mappings. Allowed values are "left", "right", and "both"."""
 	);
 
-	public ComposeMappingsCommand() {
+	public static final ComposeMappingsCommand INSTANCE = new ComposeMappingsCommand();
+
+	private ComposeMappingsCommand() {
 		super(LEFT_MAPPINGS, RIGHT_MAPPINGS, CommonArguments.MAPPING_OUTPUT, KEEP_MODE);
 	}
 

enigma-cli/src/main/java/org/quiltmc/enigma/command/ConvertMappingsCommand.java

@@ -16,7 +16,9 @@
 import java.nio.file.Path;
 
 public final class ConvertMappingsCommand extends Command {
-	public ConvertMappingsCommand() {
+	public static final ConvertMappingsCommand INSTANCE = new ConvertMappingsCommand();
+
+	private ConvertMappingsCommand() {
 		super(
 				CommonArguments.INPUT_MAPPINGS,
 				CommonArguments.MAPPING_OUTPUT,

enigma-cli/src/main/java/org/quiltmc/enigma/command/DecompileCommand.java

@@ -22,7 +22,9 @@ The decompiler to use when producing output. Allowed values are (case-insensitiv
 					- BYTECODE"""
 	);
 
-	public DecompileCommand() {
+	public static final DecompileCommand INSTANCE = new DecompileCommand();
+
+	private DecompileCommand() {
 		super(
 				ImmutableList.of(DECOMPILER, CommonArguments.INPUT_JAR, CommonArguments.OUTPUT_JAR),
 				ImmutableList.of(CommonArguments.INPUT_MAPPINGS)

enigma-cli/src/main/java/org/quiltmc/enigma/command/DeobfuscateCommand.java

@@ -7,7 +7,9 @@
 import java.nio.file.Path;
 
 public final class DeobfuscateCommand extends Command {
-	public DeobfuscateCommand() {
+	public static final DeobfuscateCommand INSTANCE = new DeobfuscateCommand();
+
+	private DeobfuscateCommand() {
 		super(
 				ImmutableList.of(CommonArguments.INPUT_JAR, CommonArguments.OUTPUT_JAR),
 				ImmutableList.of(CommonArguments.INPUT_MAPPINGS)

enigma-cli/src/main/java/org/quiltmc/enigma/command/DropInvalidMappingsCommand.java

@@ -15,7 +15,9 @@
 import java.nio.file.attribute.BasicFileAttributes;
 
 public final class DropInvalidMappingsCommand extends Command {
-	public DropInvalidMappingsCommand() {
+	public static final DropInvalidMappingsCommand INSTANCE = new DropInvalidMappingsCommand();
+
+	private DropInvalidMappingsCommand() {
 		super(
 				ImmutableList.of(CommonArguments.INPUT_JAR, CommonArguments.INPUT_MAPPINGS),
 				ImmutableList.of(CommonArguments.MAPPING_OUTPUT)

enigma-cli/src/main/java/org/quiltmc/enigma/command/FillClassMappingsCommand.java

@@ -27,7 +27,9 @@ public final class FillClassMappingsCommand extends Command {
 					Whether to fill all possible mappings. Allowed values are "true" and "false"."""
 	);
 
-	protected FillClassMappingsCommand() {
+	public static final FillClassMappingsCommand INSTANCE = new FillClassMappingsCommand();
+
+	private FillClassMappingsCommand() {
 		super(
 				ImmutableList.of(
 						CommonArguments.INPUT_JAR,
@@ -61,7 +63,7 @@ public String getDescription() {
 	}
 
 	public static void run(Path jar, Path source, Path result, boolean fillAll, @Nullable String obfuscatedNamespace, @Nullable String deobfuscatedNamespace) throws Exception {
-		boolean debug = shouldDebug(new FillClassMappingsCommand().getName());
+		boolean debug = shouldDebug(INSTANCE.getName());
 		JarIndex jarIndex = loadJar(jar);
 		Enigma enigma = createEnigma();
 

enigma-cli/src/main/java/org/quiltmc/enigma/command/HelpCommand.java

@@ -5,7 +5,9 @@
 import java.util.Collection;
 
 public final class HelpCommand extends Command {
-	protected HelpCommand() {
+	public static final HelpCommand INSTANCE = new HelpCommand();
+
+	private HelpCommand() {
 		super();
 	}
 

enigma-cli/src/main/java/org/quiltmc/enigma/command/InsertProposedMappingsCommand.java

@@ -28,7 +28,9 @@
 import javax.annotation.Nullable;
 
 public final class InsertProposedMappingsCommand extends Command {
-	public InsertProposedMappingsCommand() {
+	public static final InsertProposedMappingsCommand INSTANCE = new InsertProposedMappingsCommand();
+
+	private InsertProposedMappingsCommand() {
 		super(
 				ImmutableList.of(
 						CommonArguments.INPUT_JAR,
@@ -73,7 +75,7 @@ public static void run(Path inJar, Path source, Path output, @Nullable Path prof
 	}
 
 	public static void run(Path inJar, Path source, Path output, Enigma enigma, @Nullable String obfuscatedNamespace, @Nullable String deobfuscatedNamespace) throws Exception {
-		boolean debug = shouldDebug(new InsertProposedMappingsCommand().getName());
+		boolean debug = shouldDebug(INSTANCE.getName());
 		int nameProposalServices = enigma.getServices().get(NameProposalService.TYPE).size();
 		if (nameProposalServices == 0) {
 			Logger.error("No name proposal services found!");

enigma-cli/src/main/java/org/quiltmc/enigma/command/InvertMappingsCommand.java

@@ -20,7 +20,9 @@ public final class InvertMappingsCommand extends Command {
 					A path to the file or folder to write output to."""
 	);
 
-	public InvertMappingsCommand() {
+	public static final InvertMappingsCommand INSTANCE = new InvertMappingsCommand();
+
+	private InvertMappingsCommand() {
 		super(
 				ImmutableList.of(CommonArguments.INPUT_MAPPINGS, OUTPUT_FOLDER),
 				ImmutableList.of(CommonArguments.OBFUSCATED_NAMESPACE, CommonArguments.DEOBFUSCATED_NAMESPACE)