Skip to content

Refactor ReflectiveConfig to make InternalsHelper obsolete #50

Description

@anonymous123-code

This is the only case in the API package where internals are visible, and is confusing from the file structure point of view. It also allows for putting more complicated behavior into the helper, instead of changing the proper functions. (Like it happened in #49 (comment))

Options:

  1. Make the corresponding methods public with an individual ApiStatus.Internal annotation on each one (The now deprecated WrappedConfig did this)
  2. Move the wrapping relative stuff into an abstract ReflectiveConfigImpl which is extended by ReflectiveConfig
  3. Use reflection to set the the inner value

My current favorite is option 2.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions