-
Notifications
You must be signed in to change notification settings - Fork 452
Description
Describe the bug
The cross-origin test in tests/platform/iframe/index2.html is broken, because the test script it depends on, which was previously accessible online via
- https://partytown.builder.io/tests/platform/iframe/cross-origin.html
- https://partytown.qwik.dev/tests/platform/iframe/cross-origin.html
is no longer accessible via those URLs. Both are returning a page not found without the code needed to fulfill the test case
Reproduction
https://github.com/QwikDev/partytown
Steps to reproduce
Tests are currently broken in the main repository, because of the one that is failing:
- run the test suite
npm run test - observe test 37
iframe2.spec.tsfails - remove
testCrossOrigintest fromiframe2.spect.ts - run test suite again
- observe success
Browser Info
Chrome
Additional Information
cross-origin.html can be hosted on the Internet so that it runs in the iframe. I've created a simple solution hosting cross-origin.html as a github page in my fork of the repo, then modifying the test case accordingly.
You can see the tests are passing now:
If there's a suitable location to host a github page on the main repo (requires github admin) or github is already pointing to a project folder, I can revise my PR for the main repo.