perf: create wrapped signal only once for attributes diff

Author: Varixo

packages/qwik/src/core/client/vnode-diff.ts

@@ -831,7 +831,20 @@ export const vnode_diff = (
       }
 
       if (isSignal(value)) {
-        value = trackSignalAndAssignHost(value, vnode, key, container, NON_CONST_SUBSCRIPTION_DATA);
+        const unwrappedSignal =
+          value instanceof WrappedSignalImpl ? value.$unwrapIfSignal$() : value;
+        const currentSignal =
+          vnode?.[_EFFECT_BACK_REF]?.get(key)?.[EffectSubscriptionProp.CONSUMER];
+        if (currentSignal === unwrappedSignal) {
+          return;
+        }
+        value = trackSignalAndAssignHost(
+          unwrappedSignal,
+          vnode,
+          key,
+          container,
+          NON_CONST_SUBSCRIPTION_DATA
+        );
       }
 
       vnode.setAttr(

packages/qwik/src/core/reactive-primitives/internal-api.ts

@@ -16,7 +16,7 @@ const getProp = <T extends object, P extends keyof T>(p0: T, p1: P) => p0[p1];
 const getWrapped = <T extends object>(args: [T, (keyof T | undefined)?]) => {
   if (args.length === 1) {
     if (isSignal(args[0])) {
-      return ((args[0] as SignalImpl).$wrappedSignal$ ||= new WrappedSignalImpl(
+      return ((args[0] as unknown as SignalImpl).$wrappedSignal$ ||= new WrappedSignalImpl(
         null,
         getValueProp,
         args,
@@ -25,7 +25,7 @@ const getWrapped = <T extends object>(args: [T, (keyof T | undefined)?]) => {
     } else if (isStore(args[0])) {
       return new WrappedSignalImpl(null, getValueProp, args, null);
     }
-    return args[0].value;
+    return (args[0] as { value: T }).value;
   } else {
     return new WrappedSignalImpl(null, getProp, args, null);
   }