Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 migration tool - Error in package.json + Improvements #7194

Closed
steffanek opened this issue Dec 25, 2024 · 0 comments · Fixed by #7337
Closed

V2 migration tool - Error in package.json + Improvements #7194

steffanek opened this issue Dec 25, 2024 · 0 comments · Fixed by #7337
Assignees
Labels

Comments

@steffanek
Copy link

steffanek commented Dec 25, 2024

Error:
After running the migration, there is a need to manually update your package.json file(s) from:

"peerDependencies": {
    "@qwik.dev/core": ">=1.3.1"
  },

to:

"peerDependencies": {
    "@qwik.dev/core": ">=2.0.0-alpha.4"
  },

Improvements:
First:
There is no such import { FunctionComponent } from '@qwik.dev/core/jsx-runtime';
You can directly import { FunctionComponent } from from '@qwik.dev/core';

Second:
There is no such import type { CorrectedToggleEvent } from '@qwik.dev/core';
Instead you can: import { CorrectedToggleEvent } from '@qwik.dev/core/dist/core-internal';

ps. I encountered the following while upgrading @qwik-ui.

@steffanek steffanek changed the title V2 migration tool - Error in package.json V2 migration tool - Error in package.json + Improvements Dec 25, 2024
@Varixo Varixo added VERSION: upcoming major TYPE: bug Something isn't working labels Dec 29, 2024
@dmitry-stepanenko dmitry-stepanenko self-assigned this Feb 11, 2025
@dmitry-stepanenko dmitry-stepanenko moved this from Backlog to In progress in Qwik Development Feb 11, 2025
@gioboa gioboa closed this as completed in eb46919 Feb 13, 2025
@github-project-automation github-project-automation bot moved this from In progress to Done in Qwik Development Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants