Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion factor functions for RelativeEncoder are missing (but still referenced in comments) in REVLib 2025.0.0 #17

Open
mjhealy opened this issue Jan 13, 2025 · 1 comment

Comments

@mjhealy
Copy link

mjhealy commented Jan 13, 2025

In prior versions of the REV libraries for FRC, the RelativeEncoder interface has supported "setPositionConversionFactor" and "setVelocityConversionFactor" functions, to be used in allowing the encoder to automatically convert from native rotations/RPMs to specific units of distance/velocity (e.g., converting encoder ticks to meters/meters per second, based on gearing, wheel diameter, etc.) when reading data back from the encoders.

The current 2025 version of the RelativeEncoder interface appears to have dropped these functions. However, the documentation comments for the com.revrobotics.RelativeEncoder in the Java library still reference them on the "getPosition()", "setPosition()", and "getVelocity()" function comments, as can be seen in the screenshot below:

REV bug

As these functions are extremely useful in simplifying the handling of encoder values (vs. forcing teams to explicitly convert rotation-based numbers to "unitized values" every time), having these restored to the RelativeEncoder interface would be very helpful.

@mjhealy
Copy link
Author

mjhealy commented Jan 13, 2025

Note: these functions still seem to be present in the various *EncoderSim classes, based on the current docs, but aren't exposed through the RelativeEncoder interface, or for the real encoders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant