various fixes

Author: LandryNorris

Diff for: packages/control-hub/src/internal/ControlHub.ts

@@ -480,48 +480,48 @@ export class ControlHubInternal implements ControlHub {
 
     async readI2CMultipleBytes(
         i2cChannel: number,
-        slaveAddress: number,
+        targetAddress: number,
         numBytesToRead: number,
     ): Promise<number[]> {
         return await this.embedded.readI2CMultipleBytes(
             i2cChannel,
-            slaveAddress,
+            targetAddress,
             numBytesToRead,
         );
     }
 
-    async readI2CSingleByte(i2cChannel: number, slaveAddress: number): Promise<number> {
-        return await this.embedded.readI2CSingleByte(i2cChannel, slaveAddress);
+    async readI2CSingleByte(i2cChannel: number, targetAddress: number): Promise<number> {
+        return await this.embedded.readI2CSingleByte(i2cChannel, targetAddress);
     }
 
     async writeI2CMultipleBytes(
         i2cChannel: number,
-        slaveAddress: number,
+        targetAddress: number,
         bytes: number[],
     ): Promise<void> {
-        return await this.embedded.writeI2CMultipleBytes(i2cChannel, slaveAddress, bytes);
+        return await this.embedded.writeI2CMultipleBytes(i2cChannel, targetAddress, bytes);
     }
 
     async writeI2CReadMultipleBytes(
         i2cChannel: number,
-        slaveAddress: number,
+        targetAddress: number,
         numBytesToRead: number,
         startAddress: number,
     ): Promise<void> {
         return await this.embedded.writeI2CReadMultipleBytes(
             i2cChannel,
-            slaveAddress,
+            targetAddress,
             numBytesToRead,
             startAddress,
         );
     }
 
     async writeI2CSingleByte(
         i2cChannel: number,
-        slaveAddress: number,
+        targetAddress: number,
         byte: number,
     ): Promise<void> {
-        return await this.embedded.writeI2CSingleByte(i2cChannel, slaveAddress, byte);
+        return await this.embedded.writeI2CSingleByte(i2cChannel, targetAddress, byte);
     }
 
     async readVersion(): Promise<Version> {

Diff for: packages/control-hub/src/internal/ControlHubConnectedExpansionHub.ts

@@ -603,9 +603,9 @@ export class ControlHubConnectedExpansionHub implements ParentExpansionHub {
     }
 
     async getDigitalDirection(dioPin: number): Promise<DigitalChannelDirection> {
-        let isOutput = await this.sendCommand("getDigitalDirection", {
+        let isOutput = await this.sendCommand("isDigitalOutput", {
             hId: this.id,
-            channel: dioPin,
+            c: dioPin,
         });
 
         return isOutput ? DigitalChannelDirection.Output : DigitalChannelDirection.Input;

Diff for: packages/core/src/ExpansionHub.ts

@@ -9,8 +9,6 @@ import { VerbosityLevel } from "./VerbosityLevel.js";
 import { Version } from "./Version.js";
 import { DigitalChannelDirection } from "./DigitalChannelDirection.js";
 import { I2CSpeedCode } from "./I2CSpeedCode.js";
-import { I2CWriteStatus } from "./I2CWriteStatus.js";
-import { I2CReadStatus } from "./I2CReadStatus.js";
 import { MotorMode } from "./MotorMode.js";
 import { PidCoefficients } from "./PidCoefficients.js";
 import { PidfCoefficients } from "./PidfCoefficients.js";
@@ -30,8 +28,6 @@ export interface ExpansionHub extends RevHub {
      * it has been closed.
      */
     close(): void;
-    sendWriteCommand(packetTypeID: number, payload: number[]): Promise<number[]>;
-    sendReadCommand(packetTypeID: number, payload: number[]): Promise<number[]>;
     getModuleStatus(clearStatusAfterResponse: boolean): Promise<ModuleStatus>;
     sendKeepAlive(): Promise<void>;
     sendFailSafe(): Promise<void>;
@@ -239,7 +235,7 @@ export interface ExpansionHub extends RevHub {
      */
     readI2CRegister(
         i2cChannel: number,
-        slaveAddress: number,
+        targetAddress: number,
         numBytesToRead: number,
         register: number,
     ): Promise<number[]>;

Diff for: packages/expansion-hub/src/internal/ExpansionHub.ts

@@ -6,6 +6,7 @@ import {
     DigitalChannelDirection,
     DigitalState,
     ExpansionHub, GeneralSerialError,
+    I2cOperationInProgressError,
     I2CReadStatus,
     I2CSpeedCode,
     I2CWriteStatus,
@@ -15,7 +16,6 @@ import {
     MotorMode,
     NackCode, nackCodeToError, NoExpansionHubWithAddressError,
     ParameterOutOfRangeError,
-    I2cOperationInProgressError,
     ParentRevHub,
     PidCoefficients,
     PidfCoefficients,

Diff for: packages/sample/src/command/distance.ts

@@ -1,5 +1,5 @@
-import { ExpansionHub } from "@rev-robotics/rev-hub-core";
 import { DistanceSensor } from "@rev-robotics/distance-sensor";
+import { ExpansionHub } from "@rev-robotics/rev-hub-core";
 
 export async function distance(
     hub: ExpansionHub,

Diff for: packages/sample/src/command/list.ts

@@ -1,7 +1,7 @@
 import { openConnectedExpansionHubs } from "@rev-robotics/expansion-hub";
 import { controlHubHierarchyToString } from "../HubStringify.js";
-import {ExpansionHub} from "@rev-robotics/rev-hub-core";
-import {openUsbControlHubsAndChildren} from "../open-control-hub.js";
+import { ExpansionHub } from "@rev-robotics/rev-hub-core";
+import { openUsbControlHubsAndChildren } from "../open-control-hub.js";
 
 export async function list() {
     let usbControlHubs = await openUsbControlHubsAndChildren();

Diff for: packages/sample/src/command/log.ts

@@ -1,5 +1,4 @@
-import { DebugGroup, VerbosityLevel } from "@rev-robotics/rhsplib";
-import { ExpansionHub } from "@rev-robotics/rev-hub-core";
+import { ExpansionHub, DebugGroup, VerbosityLevel } from "@rev-robotics/rev-hub-core";
 
 export async function injectLog(hub: ExpansionHub, hint: string) {
     await hub.injectDataLogHint(hint);

Diff for: packages/sample/src/command/servo.ts

@@ -1,4 +1,4 @@
-import {ExpansionHub} from "@rev-robotics/rev-hub-core";
+import { ExpansionHub } from "@rev-robotics/rev-hub-core";
 
 export async function runServo(hub: ExpansionHub, channel: number, pulseWidth: number, framePeriod: number) {
     await hub.setServoConfiguration(channel, framePeriod);