Skip to content

Commit 32e40ff

Browse files
committed
fix(testing/cmake/CMakeLists.txt): + libhipcxx_DIR
In addition to ``` -D "NVBench_DIR=${tmp_install_prefix}/lib/cmake/nvbench/" ``` we add ``` -D "libhipcxx_DIR=${tmp_install_prefix}/lib/rapids/cmake/libhipcxx/" ``` This fixes the last failing test `nvbench.test.cmake.test_export.install_tree` to 50 %. Verbose test output: ```cmake 36: Running test command: "/opt/conda/envs/cudf_dev/bin/ctest" "--output-on-failure" 36: Test command failed: /opt/conda/envs/cudf_dev/bin/ctest 36: Test project /home/mohammad/docharri/hipdf/DEPS/hipbench/build/testing/cmake/test_export/install_tree 36: Start 1: test_bench 36: 1/2 Test #1: test_bench ....................... Passed 1.65 sec 36: Start 2: nvbench_ctl 36: 2/2 Test #2: nvbench_ctl ......................***Failed 0.00 sec 36: /home/mohammad/docharri/hipdf/DEPS/hipbench/build/testing/cmake/test_nvbench_install/bin/nvbench-ctl: error while loading shared libraries: libnvbench.so: cannot open shared object file: No such file or directory ``` The respective code is in: `testing/cmake/test_export/CMakeLists.txt` This file contains a section with the comment "# Setup LD_LIBRARY_PATH for testing". Very likely this has something to do with the remaining issue.
1 parent b91189b commit 32e40ff

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

testing/cmake/CMakeLists.txt

+2
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ nvbench_add_compile_test(test_name
5858
test_export
5959
build_tree
6060
-D "NVBench_DIR=${NVBench_BINARY_DIR}"
61+
-D "libhipcxx_DIR=${libhipcxx_BINARY_DIR}"
6162
-D TEST_TYPE=BUILD_TREE
6263
)
6364

@@ -69,6 +70,7 @@ nvbench_add_compile_test(test_name
6970
install_tree
7071
# "rapids_export() always installs to lib" per rapids_export docs
7172
-D "NVBench_DIR=${tmp_install_prefix}/lib/cmake/nvbench/"
73+
-D "libhipcxx_DIR=${tmp_install_prefix}/lib/rapids/cmake/libhipcxx/"
7274
-D TEST_TYPE=INSTALL_TREE
7375
)
7476
set_tests_properties(${test_name} PROPERTIES FIXTURES_REQUIRED install_tree)

0 commit comments

Comments
 (0)