Skip to content

Conversation

@naromero77amd
Copy link

@naromero77amd naromero77amd commented Nov 27, 2025

fast_tanhf does not support float64 and gives a compiler error. fallback to tanh for float64.

Will fix SWDEV-557937 once it is backported to release_2.8.

Related to:
pytorch#162052

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Nov 27, 2025

Jenkins build for 5a6d97ed21b12564251f03d71a008a390fc8b402 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

Copy link
Collaborator

@jataylo jataylo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but lets wait for your test suite results.

@naromero77amd
Copy link
Author

naromero77amd commented Dec 1, 2025

Ran tests as follows:

PYTORCH_TEST_WITH_ROCM=1 TEST_CONFIG=default python test/run_test.py --continue-through-error --verbose -i inductor/test_torchinductor.py  inductor/test_max_autotune.py \
    inductor/test_op_dtype_prop.py inductor/test_torchinductor_opinfo.py >& ../$logfile

I used chatgpt to analyze the logs. The following tests are now passing:

test/inductor/test_op_dtype_prop.py::TestCaseCUDA::test_dtype_aw...are_codegen_op_name_tanh_load_upcast_to_fp32_False_bfloat16_cuda
test/inductor/test_op_dtype_prop.py::TestCaseCUDA::test_dtype_aw...tanh_load_upcast_to_fp32_False_float16_cuda
test/inductor/test_op_dtype_prop.py::TestCaseCUDA::test_op_dtype_propagation_tanh_cuda_float64
test/inductor/test_torchinductor_opinfo.py::TestInductorOpInfoCUDA::test_comprehensive_nn_functional_gelu_cuda_float64
test/inductor/test_torchinductor_opinfo.py::TestInductorOpInfoCUDA::test_comprehensive_nn_functional_mish_cuda_float64
test/inductor/test_torchinductor_opinfo.py::TestInductorOpInfoCUDA::test_comprehensive_nn_functional_tanhshrink_cuda_float64
test/inductor/test_torchinductor_opinfo.py::TestInductorOpInfoCUDA::test_comprehensive_tanh_cuda_float64

there are no new regressions.

@naromero77amd naromero77amd marked this pull request as ready for review December 1, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants