fix(spur-cli): accept Slurm's --noconvert on squeue and sinfo (#647)

* fix(spur-cli): accept Slurm's --noconvert on squeue and sinfo

Slurm scripts pass --noconvert to keep output machine-parseable. Neither
command defined it, so clap rejected it as an unknown argument and a wrapper
migrated from Slurm exited non-zero having done nothing.

Spur never humanizes units in these commands: sinfo renders memory as a raw
integer and the format engine performs no conversion anywhere. The flag is
therefore accepted and deliberately inert rather than stubbed out, and output
is byte-identical whether or not it is passed. A test pins that equivalence so
the flag must be revisited if unit conversion is ever introduced.

* refactor(spur-cli): tighten --noconvert help text and test the render path

Both arg structs set disable_help_flag and re-add a long --help, and clap
uses a single-paragraph doc comment as both short and long help, so the
two-sentence rationale became the entire --help entry for the flag, beside
terse neighbours like "Don't print header". Collapse it to one line and
keep the reasoning here.

That reasoning is also narrower than the old wording claimed. On sinfo the
flag is inert because the render path already emits raw values: %m and %e
resolve to memory_mb and free_memory_mb unchanged. On squeue it is inert
for a different reason -- resolve_job_field has no size-valued specifier at
all, so there is nothing to convert either way.

Replace the parse-only test on sinfo with one that drives
render_sinfo_output over a NodeInfo fixture and asserts the memory cells
render as raw megabytes with and without the flag, so humanizing either
column fails the test. Drop the squeue counterpart: its two argv vectors
differed only by the flag under test, so no assertion could diverge, and it
used %m, which squeue does not implement.

* docs(migration): give --noconvert a home in the limitations table

That table is the canonical list of flags Spur accepts without acting on, and
the compatibility page points at it as the full list, so a flag missing from it
has no documented home. The row also records that the other four commands
Slurm defines `--noconvert` on do not accept it yet, which is the part a
migrating script actually trips over.

Two rows go the other way. `squeue --sort` and `sinfo --states` were listed as
accepted but not applied, and both have since been implemented: sorting runs
after `parse_sort_arg`, and node states are filtered server-side from the
request. A limitations table that lists working features misleads exactly the
reader it exists for.

* docs(spur-cli): tighten the --noconvert comment and migration wording

Review nits: collapse the three-line test comment, and say plainly that
squeue has no memory column rather than implying it renders raw values.

* ci: re-trigger E2E after a harness Postgres port collision

Author: nikhilsk

crates/spur-cli/src/sinfo.rs

@@ -45,6 +45,10 @@ pub struct SinfoArgs {
     #[arg(short = 'h', long)]
     pub noheader: bool,
 
+    /// Accepted for Slurm compatibility; has no effect
+    #[arg(long)]
+    pub noconvert: bool,
+
     /// Controller address
     #[arg(
         long,
@@ -350,7 +354,7 @@ mod tests {
     use super::*;
     use spur_proto::proto as pb;
     use spur_proto::proto::slurm_controller_server::SlurmController;
-    use spur_proto::proto::NodeState;
+    use spur_proto::proto::{NodeState, ResourceSet};
     use std::sync::{Arc, Mutex};
     use tonic::{Request, Response, Status};
 
@@ -392,6 +396,45 @@ mod tests {
         assert_eq!(req.states, vec![NodeState::NodeIdle as i32]);
     }
 
+    #[test]
+    fn noconvert_is_accepted() {
+        // Slurm scripts pass --noconvert to keep output machine-parseable.
+        let args = parse_sinfo_args(&["sinfo", "--noconvert"]);
+        assert!(args.noconvert);
+    }
+
+    #[test]
+    fn memory_columns_render_as_raw_megabytes_with_and_without_noconvert() {
+        // Pins that %m/%e are raw MB today; humanizing them later turns this red.
+        let mut node = make_node("gpu001", NodeState::NodeIdle, "gpu");
+        node.total_resources = Some(ResourceSet {
+            memory_mb: 2_321_924,
+            ..Default::default()
+        });
+        node.free_memory_mb = 11_077;
+        let partitions = vec![make_partition("gpu", true)];
+
+        for argv in [
+            ["sinfo", "-N", "-h", "-o", "%m %e"].as_slice(),
+            ["sinfo", "-N", "-h", "-o", "%m %e", "--noconvert"].as_slice(),
+        ] {
+            let args = parse_sinfo_args(argv);
+            let fields = format_engine::parse_format(
+                args.format.as_deref().expect("-o sets format"),
+                &format_engine::sinfo_header,
+            );
+
+            let lines = render_sinfo_output(
+                &fields,
+                &partitions,
+                std::slice::from_ref(&node),
+                args.node_oriented,
+            );
+
+            assert_eq!(lines, ["2321924 11077"], "argv: {argv:?}");
+        }
+    }
+
     #[test]
     fn state_filter_accepts_comma_separated_short_and_long_names() {
         let args = parse_sinfo_args(&["sinfo", "--states", "alloc,DOWN,draining"]);

crates/spur-cli/src/squeue.rs

@@ -57,6 +57,10 @@ pub struct SqueueArgs {
     #[arg(short = 'h', long)]
     pub noheader: bool,
 
+    /// Accepted for Slurm compatibility; has no effect
+    #[arg(long)]
+    pub noconvert: bool,
+
     /// Print help
     #[arg(long, action = clap::ArgAction::Help)]
     pub help: Option<bool>,
@@ -460,6 +464,13 @@ mod tests {
         assert_eq!(err.kind(), clap::error::ErrorKind::DisplayHelp);
     }
 
+    #[test]
+    fn noconvert_is_accepted() {
+        // Slurm scripts pass --noconvert to keep output machine-parseable.
+        let args = SqueueArgs::try_parse_from(["squeue", "--noconvert"]).unwrap();
+        assert!(args.noconvert);
+    }
+
     #[test]
     fn short_h_is_noheader_not_help() {
         let args = SqueueArgs::try_parse_from(["squeue", "-h"]).unwrap();

docs/migration-from-slurm.rst

@@ -55,10 +55,8 @@ noted as "accepted for compatibility" parse without error but have no effect yet
      - Difference
    * - Partitions
      - Defined in ``spur.conf``; there is no runtime ``scontrol create/update/delete partition``. Edit the config and reload the controller to change a partition.
-   * - ``squeue --sort``
-     - Accepted for compatibility; result ordering is not yet applied.
-   * - ``sinfo --states``
-     - Accepted for compatibility; the state filter is not yet applied (all node states are returned).
+   * - ``squeue``/``sinfo`` ``--noconvert``
+     - Accepted for compatibility; Spur already reports raw values where applicable (``sinfo``'s memory columns are MB integers; ``squeue`` has no memory column yet), so there is nothing to suppress. Slurm also defines the flag on ``sacct``, ``sstat``, ``sshare`` and ``sreport``, where it is not accepted yet.
    * - ``sacct --jobs``
      - Accepted for compatibility; the job-id filter is not yet applied server-side.
    * - ``sacct`` ``ReqMem``