Skip to content

Remove/reduce jQuery? #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Schweinepriester opened this issue Mar 21, 2022 · 1 comment · Fixed by #426
Closed

Remove/reduce jQuery? #425

Schweinepriester opened this issue Mar 21, 2022 · 1 comment · Fixed by #426
Labels
question Further information is requested

Comments

@Schweinepriester
Copy link
Contributor

Hello there!

First up, thanks for your work here! :)

Before I attempt to send a PR I wanted to gauge your stance on removing jQuery or reducing the dependence.
Primarily I had mb_caa_dimensions.user.js in mind, basically 'to improve it for myself', but if you'd like I could also drive-by reduce the usage elsewhere.

Thus: What is your stance on jQuery? May I replace some usage with modern JS or should it stay as-is?

@ROpdebee
Copy link
Owner

I've been meaning to get rid of jQuery eventually. The only place I can think of where jQuery is truly necessary is in MB: Enhanced Cover Art Edits to actually add the images, but that's using MB's own jQuery.

You're welcome to create a PR to remove jQuery from one or more scripts, but keep in mind that I'm planning to (eventually) rewrite all of the scripts to TypeScript w/ JSX (see #20), so your efforts might be in vain. However, that project has been on the backburner for a while so it'll be quite some time before that's fully finished.

@ROpdebee ROpdebee added the question Further information is requested label Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants