Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: upstream provider fixes #711

Merged
merged 6 commits into from
Dec 1, 2023
Merged

fix: upstream provider fixes #711

merged 6 commits into from
Dec 1, 2023

Conversation

ROpdebee
Copy link
Owner

@ROpdebee ROpdebee commented Nov 30, 2023 •
edited
Loading

  • Audiomack new layout
  • Updated test URLs for booth.pm

Unfixed:

  • DatPiff site is still down
  • Amazon Audible audiobook redirection is broken. If I recall correctly, if we were given a product page for an Audible audiobook, we'd rewrite to an Audible-specific page to get higher resolution images. However, that URL rewrite now leads back to the Amazon main page, so we can't use that special case anymore. @kellnerd do you know what the new Audible URL should be (or of any other tricks)?

Closes #697

@ROpdebee
fix: Audiomack new site structure
8b6404d
@ROpdebee
test: update booth.pm URLs
6a8b3db 
Two of the items were removed and had to be replaced.
@ROpdebee ROpdebee added bug Something isn't working mb_enhanced_cover_art_uploads labels Nov 30, 2023
@kellnerd
Copy link
Collaborator

kellnerd commented Nov 30, 2023 •
edited
Loading

However, that URL rewrite now leads back to the Amazon main page, so we can't use that special case anymore.

In which scenario does it redirect for you?
For me these https://www.audible.com/hz/audible/mlp/mfpdp/[ASIN] URLs are simply "Page not found" error pages now and in addition the ASINs for Audible are no longer the same as on Amazon. Our test case https://www.amazon.com/dp/B017WJ5PR4 corresponds to https://www.audible.com/pd/B017WJ5ZK6 for example.
Since that page also offers only the lousy 500x500 cover image we could skip this special handling completely. Unfortunately I haven't been able to extract any hires covers from Audible (or Amazon digital audiobooks) as of today (and haven't used it as a source for many months), so it might be no longer possible...

@ROpdebee
Copy link
Owner Author

ROpdebee commented Dec 1, 2023

I think we used to rewrite https://www.amazon.com/dp/B017WJ5PR4 to https://www.amazon.com/hz/audible/mlp/mfpdp/B017WJ5PR4 but that now redirects to https://www.amazon.com/dp/B017WJ5PR4?ref=adbl_mfpdp_geo again, at least for me. But if the cover art is limited to 500x500, I'll just remove the special case then.

@ROpdebee
refactor: remove unused handling of Amazon digital music pages
28f857d 
We've disabled support for Amazon Music pages because of the use of
an API, but the old extraction logic was still in place. Removing
it cleans up the code a bit.
@ROpdebee
fix: handle new Amazon Audible audiobook pages
fd64e31 
We used to redirect to the Audible page for audiobooks, but that
page no longer exists. Also, the Audible cover art is no longer higher
resolution than the main Amazon page. Therefore, we'll simplify the
image extraction and use the standard pages instead.
@ROpdebee
test: fix Amazon test case following upstream change
3b7993d 
Upstream data has been changed to mark the first image as the main
(and therefore front) image.
@ROpdebee
refactor: remove unused Amazon extraction logic for physical audiobooks
d1d8877 
The audiobook page is now the same as the generic page, so the special
handling of JS data extraction is no longer necessary.
@kellnerd
Copy link
Collaborator

kellnerd commented Dec 1, 2023

I think we used to rewrite https://www.amazon.com/dp/B017WJ5PR4 to https://www.amazon.com/hz/audible/mlp/mfpdp/B017WJ5PR4 but that now redirects to https://www.amazon.com/dp/B017WJ5PR4?ref=adbl_mfpdp_geo again, at least for me.

Oops, then I was imply teasting with the wrong domain yesterday. This link also redirects for me.

Interestingly, the larger image from our Audible test case still exists, but there seems to be no way to extract the image identifier from anywhere...

@ROpdebee ROpdebee merged commit f97a0c6 into main Dec 1, 2023
@ROpdebee ROpdebee deleted the upstream-provider-fixes branch December 1, 2023 14:57
@ROpdebee
Copy link
Owner Author

ROpdebee commented Dec 1, 2023

Hmm. Hopefully we find a way to extract those again later, but for now, it's better to have a 500x500 image than to have no image at all :)

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

🚀 Released 1 new userscript version(s):

  • mb_enhanced_cover_art_uploads 2023.12.1 in 1636d70

github-actions bot added a commit that referenced this pull request Dec 1, 2023
@github-actions
🤖 mb_enhanced_cover_art_uploads 2023.12.1
1636d70 
fix: upstream provider fixes (#711)
@ROpdebee
Copy link
Owner Author

Interestingly, the larger image from our Audible test case still exists, but there seems to be no way to extract the image identifier from anywhere...

Funnily enough, in #786, I changed the image extraction logic to use that of the physical product pages, and the old images are now in use again 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working deploy:success mb_enhanced_cover_art_uploads
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-record PollyJS HTTP recordings
2 participants
@ROpdebee @kellnerd