Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R/sp_distance_to_exclusion.R con capacidad para normalizar? #2

Open
violetavivi opened this issue Nov 19, 2024 · 4 comments
Open

R/sp_distance_to_exclusion.R con capacidad para normalizar? #2

violetavivi opened this issue Nov 19, 2024 · 4 comments

Comments

@violetavivi
Copy link

violetavivi commented Nov 19, 2024

Tengo una sugerencia, y es añadir un argumento adicional a la función R/sp_distance_to_exclusion.R
En lugar de hacer que:
#' @return A tibble data frame with S rows and 2 columns. Each row contains the #' species name and its great circle distance to the border where it goes #' excluded (i.e, that distance is the absolute value of the angle between #' the center and the tangent point in a given "edge" of the feasibility domain).

propongo:
#' @param norm boolean. optional. If TRUE the arc length distance to the border is normalized by 2pi (the maximum distance)

info sobre arguments opcionales en funciones de R

@AlfonsoAllen
Copy link
Collaborator

Y si damos por defecto ese valor "norm_arc_length_distance"?

@violetavivi
Copy link
Author

también!
Igual entonces tienes que cambiar un poco el código que te plotea las gráficas de vuestro paper, pero vamos, será multiplicar por 2pi

@AlfonsoAllen
Copy link
Collaborator

AlfonsoAllen commented Nov 27, 2024

Me refería a devolver un tibble con 3 columnas: nombre de la especie, distancia al borde y distancia al borde normalizada. Demasiado redundante y con potencial para descarrilar rutinas?

@violetavivi
Copy link
Author

aah mucho más elegante. Adelante con ello.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants