-
Notifications
You must be signed in to change notification settings - Fork 3.8k
fix: Miscellaneous screen reader issues (experimental) #9446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: add-screen-reader-support-experimental
Are you sure you want to change the base?
fix: Miscellaneous screen reader issues (experimental) #9446
Conversation
…laneous-screen-reader-issues
BenHenning
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finished self-review.
|
This is a bit smaller of a change so I decided not to add a video. However if that is especially important for review I am happy to make one @maribethb. |
rachel-fenichel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please check and confirm that the failing tests are due to the current test setup and not new issues.
The basics
The details
Resolves
Fixes #9301
Fixes #9312
Fixes #9313
Fixes part of #9304
Proposed Changes
This introduces a variety of specific changes to resolve several issues for screen reader work, including introducing fundamental support for field labeling.
Specifically:
Reason for Changes
This PR is largely being used as a basis for one particularly significant issue: #9301. Field labeling has undergone several iterations over the past few months and the team seems comfortable sticking with a "do as little as possible" approach when determining the label, thus justifying the need for expecting more specific customization (i.e. #9450). To this end it's important to be clear that getting fields to a good state is not actually "done" but the need to track it as a large incomplete thing has ended. Note that one important part of #9301 was updating field plugins to be accessible--this largely seems unnecessary as-is as it will be completely dependent on the needs of future user tests. The long-term plan will need to account for making all fields in
blockly-samplesaccessible (per #9307).Some of the terminology used here (e.g. for bubbles) will likely need to change after user testing, but it's important to establish that something correct is communicated even if the terminology may require scaffolding and/or refinement.
It's important to note that while non-clickable field images are no longer in the node graph, their ARIA presence still exists as part of the fluent block labeling solution. That is,
FieldImage's alt text is used as part of constructing a fluent block label (sometimes to confusing effect--see #9452).Test Coverage
No tests needed since these are experimental changes and do not change existing test behaviors.
Documentation
No documentation changes are needed for these experimental changes.
Additional Information
None.