Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The legacy JS API is deprecated warning #4

Open
ostryhub opened this issue Nov 1, 2024 · 0 comments
Open

The legacy JS API is deprecated warning #4

ostryhub opened this issue Nov 1, 2024 · 0 comments

Comments

@ostryhub
Copy link

ostryhub commented Nov 1, 2024

Hi, I am using this package with ReactUnity, I am depending on:
"@reactunity/material": "^0.18.1",
and after yarn start
I see the message about the dev server blinks in the console, but then quickly disappears and is "overriden" by lots of some js api deprecation warnings like those:

Deprecation The legacy JS API is deprecated and will be removed in Dart Sass 2.0.0.
More info: https://sass-lang.com/d/legacy-js-api

Deprecation Warning on line 0, column 8 of file:///Users/rafal/Projects/LTBL/ltbl-unity-two/react/node_modules/@reactunity/material/dist/src/alert/index.module.scss:0:8:
Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.

More info and automated migrator: https://sass-lang.com/d/import

0 | @import "../styles/variables";

../../node_modules/@reactunity/material/dist/src/alert/index.module.scss 1:9  root stylesheet

Deprecation Warning on line 0, column 8 of file:///Users/rafal/Projects/LTBL/ltbl-unity-two/react/node_modules/@reactunity/material/dist/src/styles/common/dialog.scss:0:8:
Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.

More info and automated migrator: https://sass-lang.com/d/import

0 | @import "..";

../../node_modules/@reactunity/material/dist/src/styles/common/dialog.scss 1:9  @import
../../node_modules/@reactunity/material/dist/src/alert/index.module.scss 2:9    root stylesheet

Deprecation Warning on line 0, column 8 of file:///Users/rafal/Projects/LTBL/ltbl-unity-two/react/node_modules/@reactunity/material/dist/src/styles/index.scss:0:8:
Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.

More info and automated migrator: https://sass-lang.com/d/import

In the other react package (used with ReactUnity) where I am not referencing the material package my console looks much cleaner after yarn start

it looks like this

Compiled successfully!

You can now view @react/debug-ui in the browser.

  Local:            http://localhost:3001
  On Your Network:  http://192.168.43.237:3001

Note that the development build is not optimized.
To create a production build, use npm run build.

webpack compiled successfully
Files successfully emitted, waiting for typecheck results...
Issues checking in progress...
No issues found.
  1. Is it possible the make the warnings not overwrite the initial message about the dev server ? Because when warnings happen its possible to miss the opportunity to use the previewer dev server
  2. Is is possible to update the material package to not produce those warnings?

With some initial guidance I think I could try fixing both problems and making PR
Thanks again for this great lib :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant