Skip to content

Commit ef792c1

Browse files
Change Interval and Sample default Scheduler
Change to use built-in thread-pools rather than creating a new Executor on each invocation. The built-in ones are shared across all operators, have threads ready, are marked as daemon threads so don't prevent system shutdown, and are named for clarity when looking at thread dumps and debuggers.
1 parent 2878c2a commit ef792c1

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

rxjava-core/src/main/java/rx/operators/OperationInterval.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ public final class OperationInterval {
4646
* Creates an event each time interval.
4747
*/
4848
public static OnSubscribeFunc<Long> interval(long interval, TimeUnit unit) {
49-
return interval(interval, unit, Schedulers.executor(Executors.newSingleThreadScheduledExecutor()));
49+
return interval(interval, unit, Schedulers.threadPoolForComputation());
5050
}
5151

5252
/**

rxjava-core/src/main/java/rx/operators/OperationSample.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public final class OperationSample {
4949
* Samples the observable sequence at each interval.
5050
*/
5151
public static <T> OnSubscribeFunc<T> sample(final Observable<? extends T> source, long period, TimeUnit unit) {
52-
return new Sample<T>(source, period, unit, Schedulers.executor(Executors.newSingleThreadScheduledExecutor()));
52+
return new Sample<T>(source, period, unit, Schedulers.threadPoolForComputation());
5353
}
5454

5555
/**

0 commit comments

Comments
 (0)