-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Create <rh-dropdown>
element
#425
Comments
I switched up the labels to what I think sounded right. |
See also patternfly/patternfly-elements#2049 |
<rh-dropdown>
element
Blocked by PFE 3.0 release (patternfly/patternfly-elements#2596) |
Partially exists as |
@adamjohnson @bennypowers @zeroedin, we should look into what's left to wrap up |
@markcaron, since the design here is referencing PFv4, do we want to revisit it quickly to make sure it's still the design direction we want to use? I don't think that should block starting to development for some of the typical dropdown functionality though. |
Indeed, I was just going to mention that we're missing a Figma for this component. Also relevant for the design phase:
Looking at
|
Description
Make a dropdown that can accept links or buttons that has the correct a11y properties.
PFE-Dropdown was a solid attempt at this but the aria attributes are setup incorrectly, see: patternfly/patternfly-elements#2054 (comment)
I don't know anything about Patternfly React's dropdown, but it looks like it's following the same design and has features I'd be interested in: https://www.patternfly.org/v4/components/dropdown
One pattern that PFE didn't cover that it looks like PF React Dropdown did was the dropdown should close if it loses focus, and you should only be able to have one open at a time.
Acceptance Criteria
Image
Link to design doc
https://www.patternfly.org/v4/components/dropdown/design-guidelines
Other resources
No response
The text was updated successfully, but these errors were encountered: