Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Create <rh-dropdown> element #425

Open
2 tasks
wesruv opened this issue Jul 8, 2022 · 7 comments
Open
2 tasks

[feat] Create <rh-dropdown> element #425

wesruv opened this issue Jul 8, 2022 · 7 comments
Assignees
Labels
1:1 Components with a PatternFly v4 / PatternFly Elements representation blocked Issue is blocked for dev Ready for development new component New component to be created

Comments

@wesruv
Copy link
Contributor

wesruv commented Jul 8, 2022

Description

Make a dropdown that can accept links or buttons that has the correct a11y properties.

PFE-Dropdown was a solid attempt at this but the aria attributes are setup incorrectly, see: patternfly/patternfly-elements#2054 (comment)

I don't know anything about Patternfly React's dropdown, but it looks like it's following the same design and has features I'd be interested in: https://www.patternfly.org/v4/components/dropdown

One pattern that PFE didn't cover that it looks like PF React Dropdown did was the dropdown should close if it loses focus, and you should only be able to have one open at a time.

Acceptance Criteria

  • Design done
  • Development done

Image

image

Link to design doc

https://www.patternfly.org/v4/components/dropdown/design-guidelines

Other resources

No response

@wesruv wesruv added for design Design work is requested needs discovery Needs discovery new component New component to be created labels Jul 8, 2022
@wesruv wesruv added good first issue for dev Ready for development and removed for design Design work is requested needs discovery Needs discovery labels Jul 8, 2022
@wesruv
Copy link
Contributor Author

wesruv commented Jul 8, 2022

I switched up the labels to what I think sounded right.

@bennypowers bennypowers added the 1:1 Components with a PatternFly v4 / PatternFly Elements representation label Jul 17, 2022
@bennypowers
Copy link
Member

See also patternfly/patternfly-elements#2049

@methomps methomps removed their assignment Mar 20, 2023
@markcaron markcaron added needs revisiting Outdated issues worth revisiting in the future blocked Issue is blocked and removed needs revisiting Outdated issues worth revisiting in the future labels Feb 7, 2024
@markcaron markcaron changed the title [feat] Dropdown Component [feat] Create <rh-dropdown> element Feb 8, 2024
@markcaron
Copy link
Collaborator

Blocked by PFE 3.0 release (patternfly/patternfly-elements#2596)

@hellogreg
Copy link
Collaborator

hellogreg commented Dec 12, 2024

Partially exists as rh-menu

@github-project-automation github-project-automation bot moved this from Backlog to Done ☑️ in Red Hat Design System Dec 12, 2024
@hellogreg hellogreg reopened this Dec 12, 2024
@github-project-automation github-project-automation bot moved this from Done ☑️ to In Progress 🟢 in Red Hat Design System Dec 12, 2024
@markcaron
Copy link
Collaborator

@adamjohnson @bennypowers @zeroedin, we should look into what's left to wrap up <rh-menu> to close this loop.

@marionnegp
Copy link
Collaborator

marionnegp commented Feb 13, 2025

@markcaron, since the design here is referencing PFv4, do we want to revisit it quickly to make sure it's still the design direction we want to use? I don't think that should block starting to development for some of the typical dropdown functionality though.

@adamjohnson
Copy link
Collaborator

Indeed, I was just going to mention that we're missing a Figma for this component.

Also relevant for the design phase: <rh-dropdown> is likely made for freeform content (eg: primary nav dropdowns) whereas <rh-menu> follows the APG Menu Pattern:

A menu is a widget that offers a list of choices to the user, such as a set of actions or functions. Menu widgets behave like native operating system menus, such as the menus that pull down from the menubars commonly found at the top of many desktop application windows.

Looking at <rh-menu> right now, it looks like this:

Screenshot of rh-menu and four menu items

<rh-menu> is not fully baked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1:1 Components with a PatternFly v4 / PatternFly Elements representation blocked Issue is blocked for dev Ready for development new component New component to be created
Projects
Status: In Progress 🟢
Development

No branches or pull requests

7 participants