ci: improve test_validate_resources runtime (#2442)

Author: myakove

tests/scripts/validate_resources.py

@@ -2,11 +2,14 @@
 import ast
 import json
 import os
-from typing import Any, Dict, Generator, List, Tuple
+from typing import Any, Generator
 
 
 from ocp_resources.resource import Resource  # noqa
 
+# Cache for resources definitions to avoid reloading the large JSON file
+_RESOURCES_DEFINITIONS_CACHE: dict[str, Any] = {}
+
 
 def _get_api_value_by_type(api_value: str, api_type: str) -> str:
     try:
@@ -23,9 +26,8 @@ def _get_api_value_by_type(api_value: str, api_type: str) -> str:
     return api_value
 
 
-def _get_api_group_and_version(bodies: List[Any]) -> Tuple[str, str]:
+def _get_api_group_and_version(bodies: list[Any]) -> tuple[str, str]:
     for targets in bodies:
-        targets: ast.AnnAssign | ast.Attribute
         if isinstance(targets, ast.AnnAssign):
             api_type = targets.target.id
         else:
@@ -39,11 +41,11 @@ def _get_api_group_and_version(bodies: List[Any]) -> Tuple[str, str]:
 
 def validate_resource(
     cls: ast.ClassDef,
-    resource_list: List[Dict[str, Any]],
+    resource_list: list[dict[str, Any]],
     api_value: str,
     api_type: str,
-) -> List[str]:
-    errors: List[str] = []
+) -> list[str]:
+    errors: list[str] = []
     resource_str: str = "Resource"
     namespaced_resource_str: str = "NamespacedResource"
     _base_class_error: str = f"Resource {cls.name} must have {resource_str} or {namespaced_resource_str} base class"
@@ -66,7 +68,7 @@ def validate_resource(
 
     namespaced_based: bool = base_class_from[0].id == namespaced_resource_str
     api_value_name = _get_api_value_by_type(api_value=api_value, api_type=api_type)
-    matched_resource: Dict[str, Any] = {}
+    matched_resource: dict[str, Any] = {}
 
     for resource_dict in resource_list:
         _x_kind = resource_dict["x-kubernetes-group-version-kind"]
@@ -113,8 +115,8 @@ def resource_file() -> Generator[str, None, None]:
             yield os.path.join(root, _file)
 
 
-def parse_resource_file_for_errors(data) -> List[str]:
-    errors: List[str] = []
+def parse_resource_file_for_errors(data) -> list[str]:
+    errors: list[str] = []
     _resources_definitions = resources_definitions()
 
     if data.startswith(
@@ -147,6 +149,9 @@ def parse_resource_file_for_errors(data) -> List[str]:
     return errors
 
 
-def resources_definitions() -> Dict[str, Any]:
-    with open("class_generator/schema/__resources-mappings.json") as fd:
-        return json.load(fd)
+def resources_definitions() -> dict[str, Any]:
+    global _RESOURCES_DEFINITIONS_CACHE
+    if not _RESOURCES_DEFINITIONS_CACHE:
+        with open("class_generator/schema/__resources-mappings.json") as fd:
+            _RESOURCES_DEFINITIONS_CACHE = json.load(fd)
+    return _RESOURCES_DEFINITIONS_CACHE

tests/test_validate_resources.py

@@ -1,11 +1,10 @@
-from typing import List
 import pytest
 
 from tests.scripts.validate_resources import parse_resource_file_for_errors, resource_file
 
 
 @pytest.fixture()
-def resources_definitions_errors() -> List[str]:
+def resources_definitions_errors() -> list[str]:
     errors = []
     for _file in resource_file():
         with open(_file) as fd: