Update test manifests and pre-commit config (#2576)

myakove · web-flow · commit a619e34155b5 · 2025-11-14T13:23:31.000+02:00
- Update test manifest files for various resources (APIServer, ConfigMap, DNS, Deployment, etc.)
- Update pre-commit configuration
- Update test_class_generator.py with strict zip parameter
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -10,7 +10,7 @@ ci:
 
 repos:
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: "v6.0.0"
+    rev: v6.0.0
     hooks:
       - id: check-merge-conflict
       - id: debug-statements
@@ -23,7 +23,7 @@ repos:
       - id: check-toml
 
   - repo: https://github.com/PyCQA/flake8
-    rev: "7.3.0"
+    rev: 7.3.0
     hooks:
       - id: flake8
         args: [--config=.flake8]
@@ -45,13 +45,13 @@ repos:
           ]
 
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.14.3
+    rev: v0.14.5
     hooks:
       - id: ruff
       - id: ruff-format
 
   - repo: https://github.com/gitleaks/gitleaks
-    rev: v8.28.0
+    rev: v8.29.0
     hooks:
       - id: gitleaks
 
diff --git a/class_generator/tests/manifests/APIServer/api_server.py b/class_generator/tests/manifests/APIServer/api_server.py
@@ -72,6 +72,7 @@ def __init__(
         self.tls_security_profile = tls_security_profile
 
     def to_dict(self) -> None:
+
         super().to_dict()
 
         if not self.kind_dict and not self.yaml_file:
diff --git a/class_generator/tests/manifests/ConfigMap/config_map.py b/class_generator/tests/manifests/ConfigMap/config_map.py
@@ -48,6 +48,7 @@ def __init__(
         self.immutable = immutable
 
     def to_dict(self) -> None:
+
         super().to_dict()
 
         if not self.kind_dict and not self.yaml_file:
diff --git a/class_generator/tests/manifests/DNS/dns_config_openshift_io.py b/class_generator/tests/manifests/DNS/dns_config_openshift_io.py
@@ -55,6 +55,7 @@ def __init__(
         self.public_zone = public_zone
 
     def to_dict(self) -> None:
+
         super().to_dict()
 
         if not self.kind_dict and not self.yaml_file:
diff --git a/class_generator/tests/manifests/DNS/dns_operator_openshift_io.py b/class_generator/tests/manifests/DNS/dns_operator_openshift_io.py
@@ -94,6 +94,7 @@ def __init__(
         self.upstream_resolvers = upstream_resolvers
 
     def to_dict(self) -> None:
+
         super().to_dict()
 
         if not self.kind_dict and not self.yaml_file:
diff --git a/class_generator/tests/manifests/Deployment/deployment.py b/class_generator/tests/manifests/Deployment/deployment.py
@@ -280,6 +280,7 @@ def __init__(
         self.template = template
 
     def to_dict(self) -> None:
+
         super().to_dict()
 
         if not self.kind_dict and not self.yaml_file:
diff --git a/class_generator/tests/manifests/ImageContentSourcePolicy/image_content_source_policy.py b/class_generator/tests/manifests/ImageContentSourcePolicy/image_content_source_policy.py
@@ -49,6 +49,7 @@ def __init__(
         self.repository_digest_mirrors = repository_digest_mirrors
 
     def to_dict(self) -> None:
+
         super().to_dict()
 
         if not self.kind_dict and not self.yaml_file:
diff --git a/class_generator/tests/manifests/Ingress/ingress_config_openshift_io.py b/class_generator/tests/manifests/Ingress/ingress_config_openshift_io.py
@@ -93,6 +93,7 @@ def __init__(
         self.required_hsts_policies = required_hsts_policies
 
     def to_dict(self) -> None:
+
         super().to_dict()
 
         if not self.kind_dict and not self.yaml_file:
diff --git a/class_generator/tests/manifests/Ingress/ingress_networking_k8s_io.py b/class_generator/tests/manifests/Ingress/ingress_networking_k8s_io.py
@@ -42,6 +42,7 @@ def __init__(
         self.tls = tls
 
     def to_dict(self) -> None:
+
         super().to_dict()
 
         if not self.kind_dict and not self.yaml_file:
diff --git a/class_generator/tests/manifests/Machine/machine.py b/class_generator/tests/manifests/Machine/machine.py
@@ -69,6 +69,7 @@ def __init__(
         self.taints = taints
 
     def to_dict(self) -> None:
+
         super().to_dict()
 
         if not self.kind_dict and not self.yaml_file:
diff --git a/class_generator/tests/manifests/NMState/nm_state.py b/class_generator/tests/manifests/NMState/nm_state.py
@@ -77,6 +77,7 @@ def __init__(
         self.tolerations = tolerations
 
     def to_dict(self) -> None:
+
         super().to_dict()
 
         if not self.kind_dict and not self.yaml_file:
diff --git a/class_generator/tests/manifests/OAuth/oauth.py b/class_generator/tests/manifests/OAuth/oauth.py
@@ -42,6 +42,7 @@ def __init__(
         self.token_config = token_config
 
     def to_dict(self) -> None:
+
         super().to_dict()
 
         if not self.kind_dict and not self.yaml_file:
diff --git a/class_generator/tests/manifests/Pipeline/pipeline.py b/class_generator/tests/manifests/Pipeline/pipeline.py
@@ -62,6 +62,7 @@ def __init__(
         self.workspaces = workspaces
 
     def to_dict(self) -> None:
+
         super().to_dict()
 
         if not self.kind_dict and not self.yaml_file:
diff --git a/class_generator/tests/manifests/Pod/pod.py b/class_generator/tests/manifests/Pod/pod.py
@@ -493,6 +493,7 @@ def __init__(
         self.volumes = volumes
 
     def to_dict(self) -> None:
+
         super().to_dict()
 
         if not self.kind_dict and not self.yaml_file:
diff --git a/class_generator/tests/manifests/RouteAdvertisements/route_advertisements.py b/class_generator/tests/manifests/RouteAdvertisements/route_advertisements.py
@@ -50,6 +50,7 @@ def __init__(
         self.target_vrf = target_vrf
 
     def to_dict(self) -> None:
+
         super().to_dict()
 
         if not self.kind_dict and not self.yaml_file:
diff --git a/class_generator/tests/manifests/Secret/secret.py b/class_generator/tests/manifests/Secret/secret.py
@@ -53,6 +53,7 @@ def __init__(
         self.type = type
 
     def to_dict(self) -> None:
+
         super().to_dict()
 
         if not self.kind_dict and not self.yaml_file:
diff --git a/class_generator/tests/manifests/ServiceMeshMember/service_mesh_member.py b/class_generator/tests/manifests/ServiceMeshMember/service_mesh_member.py
@@ -29,6 +29,7 @@ def __init__(
         self.control_plane_ref = control_plane_ref
 
     def to_dict(self) -> None:
+
         super().to_dict()
 
         if not self.kind_dict and not self.yaml_file:
diff --git a/class_generator/tests/manifests/ServingRuntime/serving_runtime.py b/class_generator/tests/manifests/ServingRuntime/serving_runtime.py
@@ -97,6 +97,7 @@ def __init__(
         self.volumes = volumes
 
     def to_dict(self) -> None:
+
         super().to_dict()
 
         if not self.kind_dict and not self.yaml_file:
diff --git a/class_generator/tests/test_class_generator.py b/class_generator/tests/test_class_generator.py
@@ -59,7 +59,7 @@ def _test_single_resource(kind: str, tmp_path: Path) -> tuple[str, str] | None:
                     diff_info += f"\nGenerated lines: {len(generated_lines)}, Expected lines: {len(expected_lines)}"
 
                     # Find first differing line
-                    for i, (gen_line, exp_line) in enumerate(zip(generated_lines, expected_lines, strict=False)):
+                    for i, (gen_line, exp_line) in enumerate(zip(generated_lines, expected_lines, strict=True)):
                         if gen_line != exp_line:
                             diff_info += f"\nFirst difference at line {i + 1}:"
                             diff_info += f"\nGenerated: {repr(gen_line[:100])}..."
@@ -89,22 +89,22 @@ def test_parse_explain(tmp_path: Path) -> None:
     """Test all resource kinds in parallel and collect all failures."""
     # List of all resource kinds to test
     resource_kinds = [
-        "Pod",
-        "Pipeline",
-        "OAuth",
-        "Ingress",
+        "APIServer",
         "ClusterOperator",
-        "ImageContentSourcePolicy",
-        "ServiceMeshMember",
-        "NMState",
+        "ConfigMap",
+        "DNS",
         "Deployment",
+        "ImageContentSourcePolicy",
         "Machine",
-        "APIServer",
+        "NMState",
+        "Pod",
         "Secret",
-        "ConfigMap",
-        "DNS",
-        "ServingRuntime",
+        "ServiceMeshMember",
+        "Ingress",
+        "OAuth",
+        "Pipeline",
         "RouteAdvertisements",
+        "ServingRuntime",
     ]
 
     failures: list[tuple[str, str]] = []
@@ -146,9 +146,7 @@ def create_test_task(kind: str) -> tuple[str, str] | None:
 
         # Create a concise failure message for pytest
         failed_kinds = [kind for kind, _ in failures]
-        failure_summary = f"{len(failures)} resource(s) failed: {', '.join(failed_kinds[:5])}"
-        if len(failed_kinds) > 5:
-            failure_summary += f" and {len(failed_kinds) - 5} more"
+        failure_summary = f"{len(failures)} resource(s) failed: {','.join(failed_kinds)}"
 
         # Fail the test with summary - detailed output is already printed above
         raise AssertionError(failure_summary)
