Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Animation on Cancel whilst scanning [enhancement] #341

Closed
JSmyth886 opened this issue Jun 1, 2016 · 3 comments
Closed

Animation on Cancel whilst scanning [enhancement] #341

JSmyth886 opened this issue Jun 1, 2016 · 3 comments
Labels
enhancement

Comments

@JSmyth886
Copy link

I think you could apply your boolean greater than iOS7 logic to the Cancel method within MobileBarcodeScanner class. This will allow animations for anything greater than iOS7 whilst still maintaining the bug fix for the black screen on iOS7.
@JSmyth886
Copy link
Author

I have updated my fork with the necessary changes to allow the use of this boolean to allow the animations.

@Redth
Copy link
Owner

Redth commented Jul 18, 2016

This deals with PR #345

@Redth
Copy link
Owner

Redth commented Jul 18, 2016

Closing, let's move the conversation to #345

@Redth Redth closed this as completed Jul 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Redth @JSmyth886