RTSDK-8097 Fixed the rsslReactorCloseChannel() to properly unlock the interface lock when it fails to put an event to the Reactor's queue.

soranat · soranat · commit bb4bd7aacf83 · 2023-12-22T16:56:28.000-06:00
diff --git a/Cpp-C/Eta/Impl/Reactor/rsslReactor.c b/Cpp-C/Eta/Impl/Reactor/rsslReactor.c
@@ -4596,7 +4596,11 @@ RSSL_VA_API RsslRet rsslReactorCloseChannel(RsslReactor *pReactor, RsslReactorCh
 					pReactorWarmStanbyEvent->pReactorChannel = (RsslReactorChannel*)pReactorChannel;
 
 					if (!RSSL_ERROR_INFO_CHECK(rsslReactorEventQueuePut(&pReactorImpl->reactorEventQueue, (RsslReactorEventImpl*)pReactorWarmStanbyEvent) == RSSL_RET_SUCCESS, RSSL_RET_FAILURE, pError))
-						return RSSL_RET_FAILURE;
+					{
+						_reactorShutdown(pReactorImpl, pError);
+						_reactorSendShutdownEvent(pReactorImpl, pError);
+						return (reactorUnlockInterface(pReactorImpl), RSSL_RET_FAILURE);
+					}
 				}
 				else
 				{

Original file line number	Diff line number	Diff line change
`@@ -4596,7 +4596,11 @@ RSSL_VA_API RsslRet rsslReactorCloseChannel(RsslReactor *pReactor, RsslReactorCh`
`4596`	`4596`	`pReactorWarmStanbyEvent->pReactorChannel = (RsslReactorChannel*)pReactorChannel;`
`4597`	`4597`
`4598`	`4598`	`if (!RSSL_ERROR_INFO_CHECK(rsslReactorEventQueuePut(&pReactorImpl->reactorEventQueue, (RsslReactorEventImpl*)pReactorWarmStanbyEvent) == RSSL_RET_SUCCESS, RSSL_RET_FAILURE, pError))`
`4599`		`- return RSSL_RET_FAILURE;`
	`4599`	`+ {`
	`4600`	`+ _reactorShutdown(pReactorImpl, pError);`
	`4601`	`+ _reactorSendShutdownEvent(pReactorImpl, pError);`
	`4602`	`+ return (reactorUnlockInterface(pReactorImpl), RSSL_RET_FAILURE);`
	`4603`	`+ }`
`4600`	`4604`	`}`
`4601`	`4605`	`else`
`4602`	`4606`	`{`