Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug: DirectoryConfigMap property should be used instead of DictionaryConfigMap #301

Open
lbenus opened this issue Jan 10, 2025 · 6 comments

Comments

@lbenus
Copy link

lbenus commented Jan 10, 2025

Hi guys,

I found a nasty bug in EMA C#.
#300

This was related to our scenario when we programmatically added some custom directory/service configuration. But it's not recognized so we can't publish to TREP via NI Provider.

Could you please take a look and apply?

@V-Anyakin
Copy link
Contributor

@lbenus Thank you for raising this issue and the information provided. We created an internal Jira to investigate it and to apply the provided solution.

In the meantime, let me suggest you to use a workaround, if needed: encode configuration for the Dictionary group like it is done in the example 421_MP_ProgrammaticCfg so that the condition in question is fulfilled and the corresponding Directory configuration data is copied.

@lubomir-benus
Copy link

I am already doing something similar in the code. So not sure, why the condition isn't evaluated as true. I didn't debug yet.

            configMap.AddKeyAscii("DictionaryGroup", MapAction.ADD, dictionaryGroupElementList
                .AddMap("DictionaryList", dictionaryListMap
                    .AddKeyAscii(dictionaryName, MapAction.ADD, dictionaryNameElementList
                        .AddEnum("DictionaryType", DictionaryTypeEnum.FILE)  // Default 1. Options: FileDictionary (0), ChannelDictionary (1)
                        .AddAscii("RdmFieldDictionaryFileName", fieldsPath)  // Sets the location of the RdmFieldDictionary
                        .AddAscii("EnumTypeDefFileName", enumsPath)          // Sets the location of the EnumTypeDef file
                        .Complete())
                    .Complete())
                .Complete()); 

@lubomir-benus
Copy link

Hi guys, any news regarding the above? Could you please release a hotfix of the nuget package?

Regards

@lubomir-benus
Copy link

Hi guys, any news regarding the above?

@V-Anyakin
Copy link
Contributor

@lubomir-benus we are very grateful for your contribution to discovering and fixing this issue. Could you please check your inbox, after the Contributor agreement is signed we will be able to merge the pull request. Meanwhile, a workaround or a patched library is the way to go. Thanks!

@lbenus
Copy link
Author

lbenus commented Mar 12, 2025

The agreement was signed.

Workaround doesn't work for me, I would prefer to merge the FIX and release a new nuget package.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants