Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(@videndum/release-mastermind): change was isApproved handles pending approvals #233

Open
TGTGamer opened this issue Sep 15, 2021 Discussed in #224 · 0 comments
Open

Comments

@TGTGamer
Copy link
Member

Discussed in TGTGamer/SCAA#224

Originally posted by ssfxate September 15, 2021
In our project we should have at least 2 approves, but requested reviewers could me more than 2.
2 isn't the max value. It's just the min value, but reviewers could be more, so approves could be more as well.

Have you got the same scheme (requirements) somewhere in a company/project?

We need to add options to mark / label as approved when there are still pending approvals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant