rename inlineTextPress to nestedPress

Author: Rohit3523

app/containers/markdown/components/inline/Link.tsx

@@ -9,7 +9,7 @@ import { LISTENER } from '../../../Toast';
 import { useTheme } from '../../../../theme';
 import openLink from '../../../../lib/methods/helpers/openLink';
 import EventEmitter from '../../../../lib/methods/helpers/events';
-import { claimInlineTextPress, releaseInlineTextPress } from '../../../../lib/methods/helpers/inlineTextPressClaim';
+import { beginNestedPress, endNestedPress } from '../../../../lib/methods/helpers/nestedPress';
 import { themes } from '../../../../lib/constants/colors';
 import MarkdownContext from '../../contexts/MarkdownContext';
 import styles from '../../styles';
@@ -53,8 +53,8 @@ const Link = ({ value }: ILinkProps) => {
 			style={[styles.link, ...(textStyle ? [textStyle] : []), { color: themes[theme].fontInfo }]}
 			onPress={handlePress}
 			onLongPress={onLongPress}
-			onPressIn={claimInlineTextPress}
-			onPressOut={releaseInlineTextPress}>
+			onPressIn={beginNestedPress}
+			onPressOut={endNestedPress}>
 			{(block => {
 				const blockArray = Array.isArray(block) ? block : [block];
 				return blockArray.map(blockInArray => {

app/containers/message/components/Touchable/MessageTouchable.tsx

@@ -1,7 +1,7 @@
 import { A11y } from 'react-native-a11y-order';
 
 import { useTheme } from '../../../../theme';
-import { hasInlineTextPressClaim } from '../../../../lib/methods/helpers/inlineTextPressClaim';
+import { isNestedPressActive } from '../../../../lib/methods/helpers/nestedPress';
 import Touch from '../../../Touch';
 import Message, { type TMessageProps } from '../Message/Message';
 import { useLastFocusedMessageRef } from '../../../../lib/a11y/useLastFocusedMessageRef';
@@ -49,10 +49,11 @@ const MessageTouchable = (props: TMessageProps) => {
 	}
 
 	const handleLongPress = () => {
-		// An inline markdown link already handled this long press. On Android the row is a gesture-handler
-		// Pressable and the link is a plain <Text onLongPress>, and the two gesture systems cannot arbitrate,
-		// so without this both fire and the action sheet lands on top of the "copied to clipboard" toast.
-		if (hasInlineTextPressClaim()) {
+		// A nested press target — an inline markdown link — already handled this long press. On Android the
+		// row is a gesture-handler Pressable and the link is a plain <Text onLongPress>, and the two gesture
+		// systems cannot arbitrate, so without this both fire and the action sheet lands on top of the
+		// "copied to clipboard" toast.
+		if (isNestedPressActive()) {
 			return;
 		}
 		markAsLastFocused();

app/lib/methods/helpers/inlineTextPressClaim.test.ts

@@ -0,0 +1,51 @@
+import { beginNestedPress, endNestedPress, isNestedPressActive } from './nestedPress';
+
+describe('nestedPress', () => {
+	beforeEach(() => {
+		jest.useFakeTimers();
+		endNestedPress();
+	});
+
+	afterEach(() => {
+		jest.useRealTimers();
+	});
+
+	it('reports no active press before any press', () => {
+		expect(isNestedPressActive()).toBe(false);
+	});
+
+	it('reports an active press while a nested target owns the touch', () => {
+		beginNestedPress();
+
+		expect(isNestedPressActive()).toBe(true);
+	});
+
+	it('stays active past the long press delay so the row can still be suppressed', () => {
+		beginNestedPress();
+		jest.advanceTimersByTime(500);
+
+		expect(isNestedPressActive()).toBe(true);
+	});
+
+	it('goes inactive once the press ends', () => {
+		beginNestedPress();
+		endNestedPress();
+
+		expect(isNestedPressActive()).toBe(false);
+	});
+
+	it('expires a press that never ended, so a missed release cannot wedge long press', () => {
+		beginNestedPress();
+		jest.advanceTimersByTime(1000);
+
+		expect(isNestedPressActive()).toBe(false);
+	});
+
+	it('restarts cleanly on a subsequent press', () => {
+		beginNestedPress();
+		jest.advanceTimersByTime(1000);
+		beginNestedPress();
+
+		expect(isNestedPressActive()).toBe(true);
+	});
+});

app/lib/methods/helpers/inlineTextPressClaim.ts

@@ -0,0 +1,18 @@
+// Lets a nested press target tell an ancestor it owns the current touch: on Android the message row is a
+// gesture-handler Pressable while inline markdown links are plain <Text onLongPress>, and the two gesture
+// systems cannot arbitrate, so without this a long press on a link fires both handlers.
+
+// Bounds the damage if an end is ever missed, e.g. the text unmounts mid-press.
+const MAX_PRESS_DURATION = 1000;
+
+let startedAt: number | null = null;
+
+export const beginNestedPress = () => {
+	startedAt = Date.now();
+};
+
+export const endNestedPress = () => {
+	startedAt = null;
+};
+
+export const isNestedPressActive = () => startedAt !== null && Date.now() - startedAt < MAX_PRESS_DURATION;