Skip to content

fix: add proper type for room in RoomContext #6801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

fix: add proper type for room in RoomContext #6801

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d95cb97
fix: add proper type for room in RoomContext
deepakbhagatiitr Nov 14, 2025
1be3ab4
fix: use RoomType instead of string for room type field
deepakbhagatiitr Nov 14, 2025
5044577
fix: consolidate duplicate imports in MessageComposer.test.tsx
deepakbhagatiitr Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion app/views/RoomView/context.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,33 @@
import { createContext, useContext } from 'react';

import { type ILastMessage, type TSubscriptionModel } from '../../definitions';

export type TMessageAction = 'reply' | 'quote' | 'edit' | 'react' | null;

/**
* Type for room in RoomContext, matching IRoomViewState.room
* Can be either a full TSubscriptionModel or a partial room object (e.g., for threads)
*/
export type TRoomContextRoom =
| TSubscriptionModel
| {
rid: string;
t: string;
name?: string;
fname?: string;
prid?: string;
joinCodeRequired?: boolean;
status?: string;
lastMessage?: ILastMessage;
sysMes?: boolean;
onHold?: boolean;
};

export interface IRoomContext {
rid?: string;
t?: string;
tmid?: string;
room: any; // FIXME: type it properly after we migrate RoomView to hooks
room: TRoomContextRoom;
sharing?: boolean;
action?: TMessageAction;
isAutocompleteVisible?: boolean;
Expand Down