Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: Add a comment on how to use reshape thrust curve. #659

Open
Gui-FernandesBR opened this issue Aug 19, 2024 · 0 comments · Fixed by #781
Open

DOC: Add a comment on how to use reshape thrust curve. #659

Gui-FernandesBR opened this issue Aug 19, 2024 · 0 comments · Fixed by #781
Labels
Docs Docs and examples related Good first issue Good for newcomers Motors Every propulsion related issue or PR

Comments

@Gui-FernandesBR
Copy link
Member

Gui-FernandesBR commented Aug 19, 2024 •
edited
Loading

Information is currently not clear. We need to update the docstrings in order to emphasize that the method does not mutate the object.
@Gui-FernandesBR Gui-FernandesBR added Good first issue Good for newcomers Docs Docs and examples related Motors Every propulsion related issue or PR labels Nov 2, 2024
@Gui-FernandesBR Gui-FernandesBR linked a pull request Mar 5, 2025 that will close this issue
DOCS: reshape docs (closes #659) #781
Merged
Gui-FernandesBR added a commit that referenced this issue Mar 14, 2025
@Gui-FernandesBR
DOCS: reshape docs (closes #659) (#781)
13ff9d4 
* DOC: add reference for reshaping thrust curve in documentation and improve method docstring

* MNT: fix broken ref

* DEV: update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Docs Docs and examples related Good first issue Good for newcomers Motors Every propulsion related issue or PR
Projects
LibDev Roadmap
Status: Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DOCS: reshape docs (closes #659) RocketPy-Team/RocketPy
1 participant
@Gui-FernandesBR