Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Create a RocketPy file (.rpy) to store the project #668

Open
Gui-FernandesBR opened this issue Aug 19, 2024 · 1 comment
Open

ENH: Create a RocketPy file (.rpy) to store the project #668

Gui-FernandesBR opened this issue Aug 19, 2024 · 1 comment
Assignees

Comments

@Gui-FernandesBR
Copy link
Member

There's already some draft cod in the first hackathon repo

@ArthurJWH
Copy link
Contributor

ArthurJWH commented Mar 3, 2025

Summary:
This issue is related to the creation of a JSON file that encodes and stores the objects from a simulation. Currently, the decoder returns the original objects from the simulation. This poses a problem when it comes to the class Flight, since it creates the object calling the __init__() method, which takes time to resimulate.

Tasks:

  • Create a resimulate attribute in RocketPyDecoder, with default being False
  • Code an if statement to check if resimulate attribute is False and the class is Flight
  • Create the object Flight inside the if statement with __new__() method and insert the simulation solution from the the JSON file
  • Check if all_info() method still works
  • Create a save_to_rpy() and load_from_rpy() functions in utilities
  • Create new tests
  • Document the new parameter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants