Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a linter #56

Open
e-e-e opened this issue Mar 27, 2018 · 2 comments
Open

Add a linter #56

e-e-e opened this issue Mar 27, 2018 · 2 comments
Assignees

Comments

@e-e-e
Copy link

e-e-e commented Mar 27, 2018

I just opened this #55 to remove irregular white spaces, and noticed that this repo currently does not have any linting rules. I might be useful to add to avoid future white space issues, but also help guide contributors with adopting your js style.

@RubenVerborgh
Copy link
Owner

Right, I use linters in all of my other JavaScript libraries indeed. The idea here was that most of the code is automatically generated using Jison in a format I don't control, so that a linter would not really contribute much. In #55, the issue is in lib/sparql.jison, which a linter would not catch.

However, I might do some very light linting on the result then, to check for things such as irregular whitespace.

@e-e-e
Copy link
Author

e-e-e commented Mar 29, 2018

Cool - thanks for explaining that. I have not looked at jison before, and obviously did not look closely enough. Will need to check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants